From: "Justin P. Mattock" <justinmattock@gmail.com>
To: minyard@acm.org
Cc: akpm@linux-foundation.org,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
"Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used
Date: Mon, 5 Jul 2010 21:31:02 -0700 [thread overview]
Message-ID: <1278390662-9455-1-git-send-email-justinmattock@gmail.com> (raw)
Remove addr_space in exchange for two symbols that represent
mm = IPMI_MEM_ADDR_SPACE;
io = IPMI_IO_ADDR_SPACE;
then add a dev_warn printing information so that GCC doesn't give a
warning when building the kernel.
the original warning from GCC is this:
CC [M] drivers/char/ipmi/ipmi_si_intf.o
drivers/char/ipmi/ipmi_si_intf.c: In function 'try_init_spmi':
drivers/char/ipmi/ipmi_si_intf.c:2016:8: warning: variable 'addr_space' set but not used
And also the web address pointing to a *.pdf is no where to be found(or atleast I couldn't
find it), so just use the web site itself(if somebody has the *.pdf
let me know I can change this).
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/char/ipmi/ipmi_si_intf.c | 14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 094bdc3..969e69a 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1965,8 +1965,7 @@ static int acpi_gpe_irq_setup(struct smi_info *info)
/*
* Defined at
- * http://h21007.www2.hp.com/dspp/files/unprotected/devresource/
- * Docs/TechPapers/IA64/hpspmi.pdf
+ * http://h21007.www2.hp.com/portal/site/dspp
*/
struct SPMITable {
s8 Signature[4];
@@ -2013,7 +2012,7 @@ struct SPMITable {
static __devinit int try_init_spmi(struct SPMITable *spmi)
{
struct smi_info *info;
- u8 addr_space;
+ u8 mem, io;
if (spmi->IPMIlegacy != 1) {
printk(KERN_INFO PFX "Bad SPMI legacy %d\n", spmi->IPMIlegacy);
@@ -2021,9 +2020,14 @@ static __devinit int try_init_spmi(struct SPMITable *spmi)
}
if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY)
- addr_space = IPMI_MEM_ADDR_SPACE;
+ mem = IPMI_MEM_ADDR_SPACE;
else
- addr_space = IPMI_IO_ADDR_SPACE;
+ io = IPMI_IO_ADDR_SPACE;
+
+ if (mem || io) {
+ dev_warn(info->dev, "spmi address space %d\n", mem ?: io);
+ return 0;
+ }
info = kzalloc(sizeof(*info), GFP_KERNEL);
if (!info) {
--
1.7.1.rc1.21.gf3bd6
next reply other threads:[~2010-07-06 4:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 4:31 Justin P. Mattock [this message]
2010-07-06 13:57 ` Corey Minyard
2010-07-06 14:30 ` Justin P. Mattock
2010-07-08 19:09 Justin P. Mattock
2010-07-08 20:05 ` Corey Minyard
2010-07-08 21:24 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278390662-9455-1-git-send-email-justinmattock@gmail.com \
--to=justinmattock@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®