From: Steven Rostedt <rostedt@goodmis.org>
To: Zeev Tarantov <zeev.tarantov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: 2.6.35 regression
Date: Thu, 08 Jul 2010 23:26:29 -0400 [thread overview]
Message-ID: <1278645989.1537.133.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <AANLkTilsXUjNNDcC4ZA9m8hBDqzcoh5NGbNd4XX5xx5s@mail.gmail.com>
On Thu, 2010-07-08 at 21:53 +0300, Zeev Tarantov wrote:
> With gcc 4.5.1 rev. 161655 objdump shows:
> Disassembly of section .data:
>
> ffffffff8173c438 <__start_syscalls_metadata>:
> ...
>
> ffffffff8173c440 <__syscall_meta__mmap>:
> ffffffff8173c440: 2b ab 5f 81 ff ff sub -0x7ea1(%rbx),%ebp
Yeah, this is definitely the issue. It starts off at ffffffff8173c438,
when the first item is really at ffffffff8173c440.
Can you try this patch out:
-- Steve
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 7f614ce..13ebb54 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -124,7 +124,8 @@ extern struct trace_event_functions enter_syscall_print_funcs;
extern struct trace_event_functions exit_syscall_print_funcs;
#define SYSCALL_TRACE_ENTER_EVENT(sname) \
- static struct syscall_metadata __syscall_meta_##sname; \
+ static struct syscall_metadata \
+ __attribute__((__aligned__(4))) __syscall_meta_##sname; \
static struct ftrace_event_call \
__attribute__((__aligned__(4))) event_enter_##sname; \
static struct ftrace_event_call __used \
@@ -138,7 +139,8 @@ extern struct trace_event_functions exit_syscall_print_funcs;
}
#define SYSCALL_TRACE_EXIT_EVENT(sname) \
- static struct syscall_metadata __syscall_meta_##sname; \
+ static struct syscall_metadata \
+ __attribute__((__aligned__(4))) __syscall_meta_##sname; \
static struct ftrace_event_call \
__attribute__((__aligned__(4))) event_exit_##sname; \
static struct ftrace_event_call __used \
next prev parent reply other threads:[~2010-07-09 3:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 13:04 Zeev Tarantov
2010-07-08 13:22 ` Steven Rostedt
2010-07-08 14:08 ` Sam Ravnborg
2010-07-08 14:17 ` Steven Rostedt
2010-07-08 18:53 ` Zeev Tarantov
2010-07-08 20:14 ` Steven Rostedt
2010-07-09 3:26 ` Steven Rostedt [this message]
2010-07-09 8:45 ` Zeev Tarantov
2010-07-09 13:04 ` Frederic Weisbecker
2010-07-09 14:03 ` Steven Rostedt
2010-07-09 14:10 ` Frederic Weisbecker
2010-07-09 16:52 ` Zeev Tarantov
2010-07-09 20:21 ` [tip:perf/urgent] tracing: Add alignment to syscall metadata declarations tip-bot for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278645989.1537.133.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=rjw@sisk.pl \
--cc=zeev.tarantov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®