From: "Daniel Glöckner" <dg@emlix.com>
To: David Brownell <dbrownell@users.sourceforge.net>
Cc: linux-kernel@vger.kernel.org, "Daniel Glöckner" <dg@emlix.com>
Subject: [PATCH 2/2] gpiolib: allow nested threaded irqs for poll(2)
Date: Fri, 9 Jul 2010 21:24:18 +0200 [thread overview]
Message-ID: <1278703458-26412-2-git-send-email-dg@emlix.com> (raw)
In-Reply-To: <1278703458-26412-1-git-send-email-dg@emlix.com>
The pca953x driver requires the use of threaded irqs as its irq
demultiplexer can sleep. Our irq handler can be called from any
context, so use request_any_context_irq to allow threaded irqs
as well.
Signed-off-by: Daniel Glöckner <dg@emlix.com>
Reported-by: Ian Jeffray <ian@jeffray.co.uk>
---
drivers/gpio/gpiolib.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 67e6136..b4ba1ec 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -385,9 +385,9 @@ static int gpio_setup_irq(struct gpio_desc *desc, struct device *dev,
}
}
- ret = request_irq(irq, gpio_sysfs_irq, irq_flags,
+ ret = request_any_context_irq(irq, gpio_sysfs_irq, irq_flags,
"gpiolib", value_sd);
- if (ret)
+ if (ret < 0)
goto free_id;
desc->flags |= gpio_flags;
--
1.7.1
next prev parent reply other threads:[~2010-07-09 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 19:24 [PATCH 1/2] gpiolib: get rid of struct poll_desc and worklet Daniel Glöckner
2010-07-09 19:24 ` Daniel Glöckner [this message]
2010-07-09 23:30 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278703458-26412-2-git-send-email-dg@emlix.com \
--to=dg@emlix.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®