From: Steven Rostedt <rostedt@goodmis.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Zeev Tarantov <zeev.tarantov@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Maciej@antispam.struernethosting.dk
Subject: Re: [PATCH][GIT PULL][for 2.6.35] tracing: Add alignment to syscall metadata declarations
Date: Fri, 09 Jul 2010 17:05:50 -0400 [thread overview]
Message-ID: <1278709550.1537.164.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20100709205319.GA13941@merkur.ravnborg.org>
On Fri, 2010-07-09 at 22:53 +0200, Sam Ravnborg wrote:
> But in this case we have no control of the value of "." (current address)
> when we have processed (_ftrace_events) so it may even be at a 2 byte boundary.
> The linker will add padding as needed to satisfy the alignmnet of
> __syscalls_metadata - but that padding will be inbetween "." and the first
> member in __syscalls_metadata.
Fine, but this is a separate issue. I doubt the "ALIGN(8);" would have
helped us anyway. Remember what the issue we had:
ffffffff8173c438 <__start_syscalls_metadata>:
...
ffffffff8173c440 <__syscall_meta__mmap>:
__start_syscalls_metadata was already aligned to 8, but for some strange
reason, gcc decided to align the first member to 16.
-- Steve
next prev parent reply other threads:[~2010-07-09 21:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 19:56 Steven Rostedt
2010-07-09 20:18 ` Ingo Molnar
2010-07-09 20:33 ` Sam Ravnborg
2010-07-09 20:46 ` Steven Rostedt
2010-07-09 20:53 ` Sam Ravnborg
2010-07-09 21:05 ` Steven Rostedt [this message]
2010-07-09 21:56 ` Sam Ravnborg
2010-07-09 22:02 ` Sam Ravnborg
2010-07-09 21:25 ` Linus Torvalds
2010-07-10 0:22 ` Steven Rostedt
2010-07-10 6:35 ` [PATCH] tracing: properly align linker defined symbols Sam Ravnborg
2010-07-10 10:18 ` Zeev Tarantov
2010-07-10 11:34 ` Steven Rostedt
2010-07-10 13:06 ` Zeev Tarantov
2010-07-10 13:48 ` Sam Ravnborg
2010-07-10 15:36 ` Zeev Tarantov
2010-07-10 13:49 ` Sam Ravnborg
2010-07-10 22:25 ` Linus Torvalds
2010-07-10 22:27 ` Linus Torvalds
2010-07-11 6:07 ` Sam Ravnborg
2010-07-15 15:05 ` Sam Ravnborg
2010-07-15 15:15 ` Steven Rostedt
2010-07-15 18:31 ` Sam Ravnborg
2010-07-22 11:51 ` [tip:perf/urgent] tracing: Properly " tip-bot for Sam Ravnborg
2010-07-10 9:45 ` [PATCH][GIT PULL][for 2.6.35] tracing: Add alignment to syscall metadata declarations Zeev Tarantov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278709550.1537.164.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=Maciej@antispam.struernethosting.dk \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=zeev.tarantov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®