From: Steven Rostedt <rostedt@goodmis.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
Li Hong <lihong.hi@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Matt Fleming <matt@console-pimps.org>,
Ralf Baechle <ralf@linux-mips.org>,
Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH] tracing: recordmcount.pl: Fix $mcount_regex for MIPS.
Date: Fri, 09 Jul 2010 20:26:02 -0400 [thread overview]
Message-ID: <1278721562.1537.169.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1278712325-12050-1-git-send-email-ddaney@caviumnetworks.com>
On Fri, 2010-07-09 at 14:52 -0700, David Daney wrote:
> I found this issue in a locally patched 2.6.32.x, current kernels have
> moved the offending code to an __init function which is skipped by
> recordmcount.pl, so the bug is not currently being exercised.
> However, I think the patch is still a good idea, to avoid future
> problems if _mcount were to ever have its address taken in normal
> code.
>
> This is what I originally saw:
>
> Although arch/mips/kernel/ftrace.c is built without -pg, and thus
> contains no calls to _mcount, it does use the address of _mcount
> in ftrace_make_nop(). This was causing relocations to be emitted
> for _mcount which recordmcount.pl erronously took to be _mcount
> call sites. The result was that the text of ftrace_make_nop()
> would be patched with garbage leading to a system crash.
>
> In non-module code, all _mcount call sites will have R_MIPS_26
> relocations, so we restrict $mcount_regex to only match on these.
>
I'd like to get an Acked-by from Ralf and Wu before pulling this.
Thanks,
-- Steve
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Li Hong <lihong.hi@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Matt Fleming <matt@console-pimps.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
> scripts/recordmcount.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> index f3c9c0a..0171060 100755
> --- a/scripts/recordmcount.pl
> +++ b/scripts/recordmcount.pl
> @@ -326,7 +326,7 @@ if ($arch eq "x86_64") {
> # 14: R_MIPS_NONE *ABS*
> # 18: 00020021 nop
> if ($is_module eq "0") {
> - $mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\s_mcount\$";
> + $mcount_regex = "^\\s*([0-9a-fA-F]+): R_MIPS_26\\s+_mcount\$";
> } else {
> $mcount_regex = "^\\s*([0-9a-fA-F]+): R_MIPS_HI16\\s+_mcount\$";
> }
next prev parent reply other threads:[~2010-07-10 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 21:52 David Daney
2010-07-10 0:26 ` Steven Rostedt [this message]
2010-07-10 2:12 ` Ralf Baechle
2010-07-10 3:32 ` Wu Zhangjin
2010-07-23 12:11 ` [tip:perf/core] tracing: Fix $mcount_regex for MIPS in recordmcount.pl tip-bot for David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278721562.1537.169.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=ddaney@caviumnetworks.com \
--cc=lihong.hi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®