From: Johannes Berg <johannes@sipsolutions.net>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: macbook webcam no longer works on .35-rc
Date: Mon, 12 Jul 2010 14:36:26 +0200 [thread overview]
Message-ID: <1278938186.5870.18.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201007051023.40923.laurent.pinchart@ideasonboard.com>
On Mon, 2010-07-05 at 10:23 +0200, Laurent Pinchart wrote:
> Could you please test the following patch when you will have time ?
That fixes it, thank you.
johannes
> diff --git a/drivers/media/video/uvc/uvc_ctrl.c b/drivers/media/video/uvc/uvc_ctrl.c
> index 9af4d47..a350fad 100644
> --- a/drivers/media/video/uvc/uvc_ctrl.c
> +++ b/drivers/media/video/uvc/uvc_ctrl.c
> @@ -122,8 +122,8 @@ static struct uvc_control_info uvc_ctrls[] = {
> .selector = UVC_PU_POWER_LINE_FREQUENCY_CONTROL,
> .index = 10,
> .size = 1,
> - .flags = UVC_CONTROL_SET_CUR | UVC_CONTROL_GET_RANGE
> - | UVC_CONTROL_RESTORE,
> + .flags = UVC_CONTROL_SET_CUR | UVC_CONTROL_GET_CUR
> + | UVC_CONTROL_GET_DEF | UVC_CONTROL_RESTORE,
> },
> {
> .entity = UVC_GUID_UVC_PROCESSING,
>
>
next prev parent reply other threads:[~2010-07-12 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1277932269.11050.1.camel@jlt3.sipsolutions.net>
2010-07-02 7:26 ` Johannes Berg
2010-07-05 7:28 ` Laurent Pinchart
2010-07-05 8:15 ` Johannes Berg
2010-07-05 8:23 ` Laurent Pinchart
2010-07-12 12:36 ` Johannes Berg [this message]
2010-07-12 15:34 ` Laurent Pinchart
2010-07-05 7:31 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278938186.5870.18.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®