mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jean Delvare <khali@linux-fr.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Joe Perches <joe@perches.com>,
	"David S. Miller" <davem@davemloft.net>,
	Paul Goyette <paul@whooppee.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors
Date: Mon, 12 Jul 2010 16:07:41 -0700	[thread overview]
Message-ID: <1278976061.11618.147.camel@groeck-laptop> (raw)
In-Reply-To: <20100712154949.3230beec.akpm@linux-foundation.org>

On Mon, 2010-07-12 at 18:49 -0400, Andrew Morton wrote:
> On Sun, 11 Jul 2010 07:53:04 -0700
> Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> 
> > +static int jc42_probe(struct i2c_client *new_client,
> > +		      const struct i2c_device_id *id)
> > +{
> > +	struct jc42_data *data;
> > +	int config, cap, err;
> > +
> > +	data = kzalloc(sizeof(struct jc42_data), GFP_KERNEL);
> > +	if (!data) {
> > +		err = -ENOMEM;
> > +		goto exit;
> > +	}
> > +
> > +	i2c_set_clientdata(new_client, data);
> > +	data->valid = false;
> 
> I think it would be acceptable to assume that memset(..., 0, ...) sets
> a bool to `false' ;)
> 
Guess so. Wonder where I got that from. Thanks for noticing...

Guenter



      reply	other threads:[~2010-07-12 23:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-11 14:53 Guenter Roeck
2010-07-11 15:31 ` Joe Perches
2010-07-11 16:16   ` Guenter Roeck
2010-07-11 16:21     ` Jean Delvare
2010-07-11 18:57       ` [PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line Joe Perches
2010-07-11 19:34         ` Jean Delvare
2010-07-11 19:52           ` Joe Perches
2010-07-11 21:15             ` Guenter Roeck
2010-07-12 22:49 ` [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors Andrew Morton
2010-07-12 23:07   ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278976061.11618.147.camel@groeck-laptop \
    --to=guenter.roeck@ericsson.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=davem@davemloft.net \
    --cc=hdegoede@redhat.com \
    --cc=joe@perches.com \
    --cc=khali@linux-fr.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=paul@whooppee.com \
    --cc=rdunlap@xenotime.net \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®