mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: linux-kernel@vger.kernel.org
Cc: Ben Greear <greearb@candelatech.com>
Subject: [pci] pci/mrst:  Detect loops when reading fixed BAR cap.
Date: Wed, 14 Jul 2010 10:02:03 -0700	[thread overview]
Message-ID: <1279126923-27926-1-git-send-email-greearb@candelatech.com> (raw)

The mrst logic introduced in 2.6.33-rc8 in commit
a712ffbc199849364c46e9112b93b66de08e2c26 causes boot
to hang on at least this platform:

Intel E5405 CPU
System Information
	Manufacturer: Supermicro
	Product Name: X7DBU

The cause of the hang is that pci_cap points to itself
as the next capability, putting the fixed_bar_cap into
an endless loop.

This patch detects the loop, prints a warning, and
continues on with useful work.  This strategy was
suggested by Robert Hancock <hancockrwd@gmail.com>

This should be a candidate for 2.6.34.y as well.

Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 1cdc02c... 9535ba9... M	arch/x86/pci/mrst.c
 arch/x86/pci/mrst.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/arch/x86/pci/mrst.c b/arch/x86/pci/mrst.c
index 1cdc02c..9535ba9 100644
--- a/arch/x86/pci/mrst.c
+++ b/arch/x86/pci/mrst.c
@@ -76,6 +76,17 @@ static int fixed_bar_cap(struct pci_bus *bus, unsigned int devfn)
 				return pos;
 		}
 
+		if ((pcie_cap >> 20) == 0)
+			break;
+		
+		if ((pcie_cap >> 20) <= pos) {
+			printk(KERN_WARNING "WARNING: mrst:  detected loop"
+			       " when searching for fixed BAR cap, previous"
+			       " position: 0x%x new position: 0x%x"
+			       " bus-number: %i  devfn: %i\n",
+			       pos, pcie_cap >> 20, bus->number, devfn);
+			break;
+		}
 		pos = pcie_cap >> 20;
 	}
 
-- 
1.6.2.5


             reply	other threads:[~2010-07-14 17:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14 17:02 Ben Greear [this message]
2010-07-16 17:43 ` Bjorn Helgaas
2010-07-16 17:47   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279126923-27926-1-git-send-email-greearb@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome