From: Joe Perches <joe@perches.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Alexander Kurz <linux@kbdbabel.org>,
Jiri Kosina <jkosina@suse.cz>,
Javier Martinez Canillas <martinez.javier@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] staging: msm: formatting of pointers in printk()
Date: Wed, 14 Jul 2010 11:21:44 -0700 [thread overview]
Message-ID: <1279131704.5816.3.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1279130717-15755-1-git-send-email-segooon@gmail.com>
On Wed, 2010-07-14 at 22:05 +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index 8d16380..8b49cb1 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
>
> for (i = 0; i < len; i++) {
> if (i % 16 == 0)
> - printk("\n0x%08x:", (unsigned int)cptr);
> + printk("\n%p:", cptr);
>
> printk(" %02x", *(cptr++));
> }
I was originally going to suggest a conversion
to print_hex_dump, but this function isn't used
and it and daqp_dump might as well be removed.
next prev parent reply other threads:[~2010-07-14 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 18:05 Kulikov Vasiliy
2010-07-14 18:21 ` Joe Perches [this message]
2010-07-14 20:36 ` Greg KH
2010-07-14 22:32 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279131704.5816.3.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linux@kbdbabel.org \
--cc=martinez.javier@gmail.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®