From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: ron.mercer@qlogic.com, linux-driver@qlogic.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] drivers/net/qlge: Remove duplicated initial DUMP_ macro entries
Date: Wed, 21 Jul 2010 14:19:01 -0700 [thread overview]
Message-ID: <1279747141.1909.22.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100721.135800.43444396.davem@davemloft.net>
There are a couple of errors in the previous patch.
Two of the first DUMP_<foo> entries are duplicated.
Sorry, bad use of emacs macros...
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/qlge/qlge_dbg.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qlge/qlge_dbg.c b/drivers/net/qlge/qlge_dbg.c
index 9d9498b..4747492 100644
--- a/drivers/net/qlge/qlge_dbg.c
+++ b/drivers/net/qlge/qlge_dbg.c
@@ -1465,7 +1465,6 @@ void ql_dump_regs(struct ql_adapter *qdev)
{
pr_err("reg dump for function #%d\n", qdev->func);
DUMP_REG(qdev, SYS);
- DUMP_REG(qdev, SYS);
DUMP_REG(qdev, RST_FO);
DUMP_REG(qdev, FSC);
DUMP_REG(qdev, CSR);
@@ -1535,7 +1534,6 @@ void ql_dump_stat(struct ql_adapter *qdev)
{
pr_err("%s: Enter\n", __func__);
DUMP_STAT(qdev, tx_pkts);
- DUMP_STAT(qdev, tx_pkts);
DUMP_STAT(qdev, tx_bytes);
DUMP_STAT(qdev, tx_mcast_pkts);
DUMP_STAT(qdev, tx_bcast_pkts);
next prev parent reply other threads:[~2010-07-21 21:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 21:49 [PATCH net-next] drivers/net/qlge: Use pr_<level>, shrink text a bit Joe Perches
2010-07-21 20:58 ` David Miller
2010-07-21 21:19 ` Joe Perches [this message]
2010-07-21 21:43 ` [PATCH net-next] drivers/net/qlge: Remove duplicated initial DUMP_ macro entries David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279747141.1909.22.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®