From: Steven Rostedt <rostedt@goodmis.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: Don't SIGSEGV when event field format cannot be parsed.
Date: Thu, 22 Jul 2010 16:08:45 -0400 [thread overview]
Message-ID: <1279829325.3319.27.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1279046692-11941-1-git-send-email-ddaney@caviumnetworks.com>
On Tue, 2010-07-13 at 11:44 -0700, David Daney wrote:
> >From the MIPS kernel we get things like:
>
> print fmt: "page=%p pfn=%lu order=%d migratetype=%d", REC->page, ({ struct page *__pg = (REC->page); int __sec = page_to_section(__pg); (unsigned long)(__pg - __section_mem_map_addr(__nr_to_section(__sec))); }), REC->order, REC->migratetype
>
> This cannot be parsed, leading to a NULL struct event_format* being
> passed to pevent_get_common_field_val, which produces a SIGSEGV. It
> would be good to get a parsable format from the kernel, but to
> remediate the problem for legacy kernels, we can just return an error
> indicator in this case. This allows some output from trace-cmd
> report, although perhaps with some missing data. But this is better
> than crashing.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> ---
> parse-events.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/parse-events.c b/parse-events.c
> index 9d5a3fa..16fff12 100644
> --- a/parse-events.c
> +++ b/parse-events.c
> @@ -4481,6 +4481,9 @@ int pevent_get_common_field_val(struct trace_seq *s, struct event_format *event,
> {
To be consistent, probably all the pevent_get_*field* should test for
null event.
Did you want to resend a patch that does that?
-- Steve
> struct format_field *field;
>
> + if (!event)
> + return -1;
> +
> field = pevent_find_common_field(event, name);
>
> return get_field_val(s, field, name, record, val, err);
next prev parent reply other threads:[~2010-07-22 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 18:44 David Daney
2010-07-22 20:08 ` Steven Rostedt [this message]
2010-07-22 21:05 ` [PATCH] trace-cmd: Don't SIGSEGV when event field format cannot be parsed (v2) David Daney
2010-07-23 15:10 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279829325.3319.27.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®