From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbdLFLwa (ORCPT ); Wed, 6 Dec 2017 06:52:30 -0500 Received: from mout.web.de ([212.227.15.14]:64717 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751362AbdLFLw0 (ORCPT ); Wed, 6 Dec 2017 06:52:26 -0500 To: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Johan Hovold Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] USB: emi62: Delete an error message for a failed memory allocation in emi62_writememory() Message-ID: <127ca958-ef62-dbda-5329-02252c1a2763@users.sourceforge.net> Date: Wed, 6 Dec 2017 12:52:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:UrNJPUz+46vt8hjz0I8B2wHl7zXjAgABOQhHkr9qlxJa1gpNfdt +G4tFh/M56F+qq7cK8ohNttlxyM8UOlshvqeUaEPts7Q/pJGgfzDOAK3cqx7tzu62I1Mx1w JNG7ungmjmujtOYQ5LYPOYPS7XaI9HaaRZFMm3Ttg5ET0ca9rU0mVzRsU8FQUSrnU1VrcVE qnVJDE81urbnMpNO4WF5Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:Y32xomhiqz8=:u9d+VqOxTjCdoEpBSlAWtc RcPsuaLdZI9X3SjOIHDCXbFIl4G9lF851uzN2VKvN3xMECE1erLtdbzg/3IFYFXsMj6ryjZ26 R2XvhH3xPIsvk5pt5wEsyMd57w3ewAvApVoxlSIOj2bwY9NSemd9YcIoWVUf2s/PSiJW0g61s jSMF4qheLoqrNzG7p6ASlz+C2Y4IrZoAm7/7rI4zfcqt1k5KeD168Au8xs/sMiKtrT51flsQ4 ygEULxyRjzug1UfizEYcgR0vqXyaDbIJspzC17RcHil2k96pxBa8Nc3cRNeXGbqIiCMEgEURk AWa/IFJveeqE+xvlXlOAf1M3LF7CAzeEGbmHohVnZ+CR7D+Y6I4Mjxh8YAZasbJz1D+wxkKwF 9FSCfl8wUGLyNY6L6bcxC0/+H3EWClm3YBGt+7QGkGT+fW4Lrvl7LBNGXRr8Bvb/EiqRLFXzk J0EA7VAkzOuq6J0Fo/zuWdYB4TtbvBEPJ/EVsYdRtnHgeAWyYizecKD4YDcNdEDjGWhWpHEoy j8NwXytM/CnrggmFJSE4TIJBP4u4SKrnjUA4DzALaX9Xw4Sa42x0LaFP0+l8lwLgBKfzB7ktm GFyz7m4knRDDoChgzrAYvpJwhXtcuF5oYKP6Tb14ERTOdt2zsb5cNF8V0ljoufGN+s0n2gpOP owI1P6Km6rqQbVXXdTflvOEA8O7ys4LQiSije5lMRDG7QCWvb3zYDCA6XT/JTm4a56cGSKegq GwFd4Xvp5JRJLNLGjEy9a6tR5naATeIL6oSLYctEa27sfC/yMAC5e+R7LMzWzV9TdemSRurIq xOL4BlxHSTUNFwMMxNN+jjnJ6vQ2mM2lroTLAizBqmoNJtiwtU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 6 Dec 2017 12:42:20 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/usb/misc/emi62.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/emi62.c b/drivers/usb/misc/emi62.c index 3eea60437f56..f85946731aaa 100644 --- a/drivers/usb/misc/emi62.c +++ b/drivers/usb/misc/emi62.c @@ -51,10 +51,9 @@ static int emi62_writememory(struct usb_device *dev, int address, int result; unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); - if (!buffer) { - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length); + if (!buffer) return -ENOMEM; - } + /* Note: usb_control_msg returns negative value on error or length of the * data that was written! */ result = usb_control_msg (dev, usb_sndctrlpipe(dev, 0), request, 0x40, address, 0, buffer, length, 300); -- 2.15.1