From: Catalin Marinas <catalin.marinas@arm.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH] lib/scatterlist: Hook sg_kmalloc into kmemleak
Date: Mon, 26 Jul 2010 21:55:44 +0100 [thread overview]
Message-ID: <1280177744.27682.2.camel@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <1280067675-7610-1-git-send-email-chris@chris-wilson.co.uk>
On Sun, 2010-07-25 at 15:21 +0100, Chris Wilson wrote:
> kmemleak ignores page_alloc() and so believes the final sub-page
> allocation using the plain kmalloc is decoupled and lost. This leads to
> lots of false-positives with code that uses scatterlists.
>
> The options seem to be either to tell kmemleak that the kmalloc is not
> leaked or to notify kmemleak of the page allocations. The danger of the
> first approach is that we may hide a real leak, so choose the latter
> approach (of which I am not sure of the downsides).
The patch looks fine to me. It would be useful to have some comment
where kmemleak_*() functions are called so that people reading the code
know why they are needed.
Thanks.
--
Catalin
next prev parent reply other threads:[~2010-07-26 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 14:21 Chris Wilson
2010-07-26 20:55 ` Catalin Marinas [this message]
2010-07-27 8:44 ` [PATCH] lib/scatterlist: Hook sg_kmalloc into kmemleak (v2) Chris Wilson
2010-07-28 21:32 ` Catalin Marinas
2010-08-10 22:01 ` Catalin Marinas
2010-08-10 23:56 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280177744.27682.2.camel@e102109-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=chris@chris-wilson.co.uk \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®