mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ernesto Ramos <ernesto@ti.com>
To: gregkh@suse.de
Cc: omar.ramirez@ti.com, ohad@wizery.com, ameya.palande@nokia.com,
	felipe.contreras@nokia.com, fernando.lugo@ti.com,
	linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com,
	nm@ti.com, linux-omap@vger.kernel.org,
	Ernesto Ramos <ernesto@ti.com>
Subject: [PATCH 2/4] staging:ti dspbridge: proc_load/start should set IVA2 to OFF in case of failure
Date: Wed, 28 Jul 2010 09:54:53 -0500	[thread overview]
Message-ID: <1280328895-31375-3-git-send-email-ernesto@ti.com> (raw)
In-Reply-To: <1280328895-31375-2-git-send-email-ernesto@ti.com>

When a base image is being loaded or started and by some reason
the process fails, the IVA2 should be switched OFF.

Signed-off-by: Ernesto Ramos <ernesto@ti.com>
---
 drivers/staging/tidspbridge/rmgr/proc.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/tidspbridge/rmgr/proc.c b/drivers/staging/tidspbridge/rmgr/proc.c
index 6258d8b..44c26e1 100644
--- a/drivers/staging/tidspbridge/rmgr/proc.c
+++ b/drivers/staging/tidspbridge/rmgr/proc.c
@@ -1302,9 +1302,10 @@ int proc_load(void *hprocessor, const s32 argc_index,
 	}
 
 func_end:
-	if (status)
+	if (status) {
 		pr_err("%s: Processor failed to load\n", __func__);
-
+		proc_stop(p_proc_object);
+	}
 	DBC_ENSURE((!status
 		    && p_proc_object->proc_state == PROC_LOADED)
 		   || status);
@@ -1594,6 +1595,7 @@ func_cont:
 		}
 	} else {
 		pr_err("%s: Failed to start the dsp\n", __func__);
+		proc_stop(p_proc_object);
 	}
 
 func_end:
-- 
1.5.4.5


  reply	other threads:[~2010-07-28 14:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 14:54 [PATCH 0/4] staging:ti dspbridge: Fix IVA2 power OFF series Ernesto Ramos
2010-07-28 14:54 ` [PATCH 1/4] staging:ti dspbridge: fix bridge_brd_stop so IVA2 is set OFF Ernesto Ramos
2010-07-28 14:54   ` Ernesto Ramos [this message]
2010-07-28 14:54     ` [PATCH 3/4] staging:ti dspbridge: make sure IVA2 is OFF when dev is created Ernesto Ramos
2010-07-28 14:54       ` [PATCH 4/4] staging:ti dspbridge: remove bridge_brd_delete function Ernesto Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280328895-31375-3-git-send-email-ernesto@ti.com \
    --to=ernesto@ti.com \
    --cc=ameya.palande@nokia.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=felipe.contreras@nokia.com \
    --cc=fernando.lugo@ti.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ohad@wizery.com \
    --cc=omar.ramirez@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®