mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Samuel Moelius <sam.moelius@trailofbits.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: scsi_debug: fix one-partition tape setup bounds
Date: Wed, 03 Jun 2026 16:45:57 -0400	[thread overview]
Message-ID: <1280577210aa54ba9a769ff39c3bfa797bbd32c3.camel@HansenPartnership.com> (raw)
In-Reply-To: <20260603182518.27082-1-sam.moelius@trailofbits.com>

On Wed, 2026-06-03 at 18:25 +0000, Samuel Moelius wrote:
> The tape setup path writes partition metadata one element past the
> allocated tape_blocks array when a one-partition configuration is
> selected.

I don't think that's correct.  tape_blocks is defined in struct
sdebug_dev_info as

	struct tape_block *tape_blocks[TAPE_MAX_PARTITIONS];

so tape_blocks[1] is always allocated.  You can argue it shouldn't be
written to even though it is allocated, but that's not what you wrote.

Regards,

James


  reply	other threads:[~2026-06-03 20:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 18:25 Samuel Moelius
2026-06-03 20:45 ` James Bottomley [this message]
2026-06-03 21:41   ` Samuel Moelius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280577210aa54ba9a769ff39c3bfa797bbd32c3.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sam.moelius@trailofbits.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®