From: Stefan Weil <weil@mail.berlios.de>
To: linux-kernel@vger.kernel.org
Cc: Stefan Weil <weil@mail.berlios.de>,
"David S. Miller" <davem@davemloft.net>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Ben Hutchings <ben@decadent.org.uk>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Subject: [PATCH] phy: Add missing forward declaration (fixes compiler warning)
Date: Tue, 3 Aug 2010 19:04:01 +0200 [thread overview]
Message-ID: <1280855041-4063-1-git-send-email-weil@mail.berlios.de> (raw)
Without forward declaration for struct sk_buff, compilation
of drivers/net/phy/fixed.c results in a warning:
CC drivers/net/phy/fixed.o
In file included from drivers/net/phy/fixed.c:20:
include/linux/phy.h:342: warning: 'struct sk_buff' declared inside parameter list
include/linux/phy.h:342: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/phy.h:343: warning: 'struct sk_buff' declared inside parameter list
(tested with linux kernel for openwrt / ar7, gcc-4.1.2)
Cc: David S. Miller <davem@davemloft.net>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
include/linux/phy.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 987e111..65e8d72 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -51,6 +51,8 @@
#define PHY_HAS_INTERRUPT 0x00000001
#define PHY_HAS_MAGICANEG 0x00000002
+struct sk_buff;
+
/* Interface Mode definitions */
typedef enum {
PHY_INTERFACE_MODE_MII,
--
1.5.6.5
next reply other threads:[~2010-08-03 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 17:04 Stefan Weil [this message]
2010-08-15 7:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280855041-4063-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=avorontsov@ru.mvista.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®