From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Alex Dubov <oakad@yahoo.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] MEMSTICK: fix hangs on unexpected device removal in mspro_blk
Date: Wed, 04 Aug 2010 19:53:41 +0300 [thread overview]
Message-ID: <1280940821.16380.10.camel@maxim-laptop> (raw)
In-Reply-To: <811063.41186.qm@web37605.mail.mud.yahoo.com>
On Wed, 2010-08-04 at 00:50 -0700, Alex Dubov wrote:
> --- On Tue, 3/8/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
>
> > Now that del_gendisk syncs, we better
> > start rejecting requests right away.
>
>
> I don't quite see why this change is needed. My understanding is, user
> accessible interface should be marked as removed as early, as possible.
The problem here is that del_gendisk, syncs the device.
This is new change, made after you did your drivers.
I have this problem on jMicron too (which otherwise works fine).
PS:
I have a copy of your ms_block.c.
I would would be very happy if you share with me, what problems does it
still have (besides need of trivial port for changes in block system,
because I want to push it upstream too.
I have MS DUO 64M to test it against.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2010-08-04 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 14:53 [PATCH 0/2] Driver for Ricoh cardreader Maxim Levitsky
2010-08-03 14:53 ` [PATCH 1/2] MEMSTICK: fix hangs on unexpected device removal in mspro_blk Maxim Levitsky
2010-08-04 7:50 ` Alex Dubov
2010-08-04 16:53 ` Maxim Levitsky [this message]
2010-08-04 21:41 ` Maxim Levitsky
2010-08-05 8:43 ` Alex Dubov
2010-08-05 17:48 ` Maxim Levitsky
2010-08-06 7:37 ` Alex Dubov
2010-08-03 14:53 ` [PATCH 2/2] MEMSTICK: Add driver for Ricoh R5C592 Card reader Maxim Levitsky
2010-08-04 7:57 ` Alex Dubov
2010-08-04 16:48 ` Maxim Levitsky
2010-08-04 19:31 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280940821.16380.10.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oakad@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®