From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933355Ab0HEOjQ (ORCPT ); Thu, 5 Aug 2010 10:39:16 -0400 Received: from mail.windriver.com ([147.11.1.11]:41249 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760686Ab0HEOi4 (ORCPT ); Thu, 5 Aug 2010 10:38:56 -0400 From: Jason Wessel To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, Jason Wessel , Andrew Morton , Ingo Molnar , linux-mm@kvack.org Subject: [PATCH 14/17] mm,kdb,kgdb: Add a debug reference for the kdb kmap usage Date: Thu, 5 Aug 2010 09:37:55 -0500 Message-Id: <1281019078-6636-15-git-send-email-jason.wessel@windriver.com> X-Mailer: git-send-email 1.6.4.rc1 In-Reply-To: <1281019078-6636-14-git-send-email-jason.wessel@windriver.com> References: <1281019078-6636-1-git-send-email-jason.wessel@windriver.com> <1281019078-6636-2-git-send-email-jason.wessel@windriver.com> <1281019078-6636-3-git-send-email-jason.wessel@windriver.com> <1281019078-6636-4-git-send-email-jason.wessel@windriver.com> <1281019078-6636-5-git-send-email-jason.wessel@windriver.com> <1281019078-6636-6-git-send-email-jason.wessel@windriver.com> <1281019078-6636-7-git-send-email-jason.wessel@windriver.com> <1281019078-6636-8-git-send-email-jason.wessel@windriver.com> <1281019078-6636-9-git-send-email-jason.wessel@windriver.com> <1281019078-6636-10-git-send-email-jason.wessel@windriver.com> <1281019078-6636-11-git-send-email-jason.wessel@windriver.com> <1281019078-6636-12-git-send-email-jason.wessel@windriver.com> <1281019078-6636-13-git-send-email-jason.wessel@windriver.com> <1281019078-6636-14-git-send-email-jason.wessel@windriver.com> X-OriginalArrivalTime: 05 Aug 2010 14:38:22.0574 (UTC) FILETIME=[DAD698E0:01CB34AB] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kdb kmap should never get used outside of the kernel debugger exception context. Signed-off-by: Jason Wessel CC: Andrew Morton CC: Ingo Molnar CC: linux-mm@kvack.org --- mm/highmem.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/mm/highmem.c b/mm/highmem.c index 66baa20..7a0aa1b 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -26,6 +26,7 @@ #include #include #include +#include #include /* @@ -470,6 +471,12 @@ void debug_kmap_atomic(enum km_type type) warn_count--; } } +#ifdef CONFIG_KGDB_KDB + if (unlikely(type == KM_KDB && atomic_read(&kgdb_active) == -1)) { + WARN_ON(1); + warn_count--; + } +#endif /* CONFIG_KGDB_KDB */ } #endif -- 1.6.3.3