From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755485Ab0HHTN3 (ORCPT ); Sun, 8 Aug 2010 15:13:29 -0400 Received: from mms1.broadcom.com ([216.31.210.17]:4198 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753641Ab0HHTN2 (ORCPT ); Sun, 8 Aug 2010 15:13:28 -0400 X-Server-Uuid: 02CED230-5797-4B57-9875-D5D2FEE4708A Subject: Re: [PATCH 32/42] drivers/net/bnx2x: Adjust confusing if indentation From: "Eilon Greenstein" Reply-to: eilong@broadcom.com To: "Julia Lawall" cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , yanivr@broadcom.com In-Reply-To: References: Organization: Broadcom Date: Sun, 8 Aug 2010 22:13:05 +0300 Message-ID: <1281294785.21680.3.camel@lb-tlvb-eilong.il.broadcom.com> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 X-WSS-ID: 6041DE4637O54009310-01-01 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2010-08-05 at 13:26 -0700, Julia Lawall wrote: > From: Julia Lawall > > Outdent the code following the if. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @r disable braces4@ > position p1,p2; > statement S1,S2; > @@ > > ( > if (...) { ... } > | > if (...) S1@p1 S2@p2 > ) > > @script:python@ > p1 << r.p1; > p2 << r.p2; > @@ > > if (p1[0].column == p2[0].column): > cocci.print_main("branch",p1) > cocci.print_secs("after",p2) > // > > Signed-off-by: Julia Lawall Acked-by: Eilon Greenstein > --- > This patch doesn't change the semantics of the code. But it might not be > what is intended. This is indeed just bad alignment, thanks for the fix