From: Joe Perches <joe@perches.com>
To: Stepan Moskovchenko <stepanm@codeaurora.org>
Cc: dwalker@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] arm: msm: Add MSM IOMMU support.
Date: Mon, 09 Aug 2010 20:08:09 -0700 [thread overview]
Message-ID: <1281409689.1954.96.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1281407259-28626-1-git-send-email-stepanm@codeaurora.org>
On Mon, 2010-08-09 at 19:27 -0700, Stepan Moskovchenko wrote:
> Add support for the IOMMUs found on the upcoming Qualcomm
> MSM8x60 chips. These IOMMUs allow virtualization of the
> address space used by most of the multimedia cores on these
> chips. The driver implements the kernel's IOMMU API.
> diff --git a/arch/arm/mach-msm/iommu.c b/arch/arm/mach-msm/iommu.c
> new file mode 100644
> index 0000000..b22aecd
> --- /dev/null
> +++ b/arch/arm/mach-msm/iommu.c
> @@ -0,0 +1,601 @@
Why use both pr_err and printk(KERN_ERR ?
> +#define pr_fmt(fmt) "%s %i " fmt, __func__, __LINE__
> + pr_err("bad size: %d\n", len);
> + pr_err("null page table\n");
> + pr_err("could not allocate second level table\n");
> + pr_err("null page table\n");
> + pr_err("first level PTE is 0\n");
> + printk(KERN_ERR "FAR = %08x PAR = %08x\n",
> + printk(KERN_ERR "FSR = %08x [%s%s%s%s%s%s%s%s%s%s]\n", fsr,
> + printk(KERN_ERR "FSYNR0 = %08x FSYNR1 = %08x\n",
> + printk(KERN_ERR "TTBR0 = %08x TTBR1 = %08x\n",
> + printk(KERN_ERR "SCTLR = %08x ACTLR = %08x\n",
> + printk(KERN_ERR "PRRR = %08x NMRR = %08x\n",
> + pr_err("Invalid device ID in context interrupt handler\n");
> + printk(KERN_ERR "===== WOAH! =====\n");
> + printk(KERN_ERR "Unexpected IOMMU page fault!\n");
> + printk(KERN_ERR "base = %08x\n", (unsigned int) base);
> + printk(KERN_ERR "Fault occurred in context %d.\n", i);
> + printk(KERN_ERR "Interesting registers:\n");
> + printk(KERN_ERR "\n");
next prev parent reply other threads:[~2010-08-10 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 2:27 Stepan Moskovchenko
2010-08-10 3:08 ` Joe Perches [this message]
2010-08-10 3:42 ` stepanm
2010-08-10 5:36 ` Joe Perches
2010-08-10 19:22 ` stepanm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281409689.1954.96.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®