From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81FC525F979; Wed, 11 Jun 2025 09:33:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749634427; cv=none; b=YIjhzCtPCOghyHjzE1JEZpa27EJaltuU5xRdVptubqNDwJzh3HWdEqfPDswnGs3Ifygko2halgBhTY0m+i6VPAtpYXzGk+jdxzqQbdDy+5cngohKbn+BWskLGFoOPKIXCOtTZkbcVoHCSfE/AwmhA4T/ndnuYHUqJi7AUOBu0HA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749634427; c=relaxed/simple; bh=lAO7ICT8rPi2jW/yKmCQoIc5yJNSzG6H883GDZTA6Eg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j7BgtC3JppxyVNjtoBtc1y88awkQTOFUgBDyffwcNMKL5AiY6LVEveo1jdPCXjsYT6DYsqQuqKqs1OH7UbsNby4mMJfPdrM79Y3jh1bXx1j5Qv1oKAE15ZLlLYtdNzP5huhTtqpZ97hmryHxUvTOK3Gcx/ULDyyt4cKdPJdWd54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=OaYEbMNu; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="OaYEbMNu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1749634423; bh=lAO7ICT8rPi2jW/yKmCQoIc5yJNSzG6H883GDZTA6Eg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OaYEbMNudDi8ORJRv5JVQtJGvVka/LQLBHfvrTI/7GMZbfUSONdbHLFx5Sud+94ZY K44xXTp7i6goU83CFlmdDpcFtQk6gvCc7vDWoSaLKCdoRZdBA4ulZppatpjbtcdtLG vrlX65aGJo8JUrl337gzmeXj5k0tN3kfes5aefLkRFgKchXgflY+Z0tB6qwh4yRcZx /jq8u0eqAH59fg0Gl8SwVR/NbKscxrT7QXwA9BDI8I4AVdaPNJ5jlk7Cjl5QjR+Y5O OXUlGjDVYSaYIsCwwbWJ6ybsOruAea2A3NXWy/5+9C4I9CxFXkuXRLtY3MFEwQHzV0 7WUCcv0/qmdpQ== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 253A617E3626; Wed, 11 Jun 2025 11:33:42 +0200 (CEST) Message-ID: <12816e74-9708-4e83-939a-347e1f6f6f5c@collabora.com> Date: Wed, 11 Jun 2025 11:33:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/13] arm64: dts: mediatek: mt7988a-bpi-r4: add gpio leds To: Frank Wunderlich , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger Cc: Frank Wunderlich , Jia-Wei Chang , Johnson Wang , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Landen Chao , DENG Qingfang , Sean Wang , Daniel Golle , Lorenzo Bianconi , Felix Fietkau , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20250608211452.72920-1-linux@fw-web.de> <20250608211452.72920-11-linux@fw-web.de> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20250608211452.72920-11-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 08/06/25 23:14, Frank Wunderlich ha scritto: > From: Frank Wunderlich > > Bananapi R4 has a green and a blue led which can be switched by gpio. > Green led is for running state so default on. > > Green led also shares pin with eeprom writeprotect where led off allows > writing to eeprom. This is extremely ugly from a hardware perspective and I'm sad to see such a thing here. Though, I don't see any other solution, so I can only give you an advice: don't ever write to the eeprom from the kernel. Things will eventually go south otherwise. I would also advise to add a read-only property to the eeprom node. Regardless (and sadly), Reviewed-by: AngeloGioacchino Del Regno