From: hiromu <hiromu1996@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Toralf Foerster" <toralf.foerster@gmx.de>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
"YOSHIFUJI Hideaki" <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH] kconfig: Fix variable name typo in streamline_config.pl.
Date: Tue, 17 Aug 2010 19:49:18 +0900 [thread overview]
Message-ID: <1282042158.7160.9.camel@hiromu-Macbook> (raw)
In-Reply-To: <20100817054318.GC5095@cr0.nay.redhat.com>
On Fri, Aug 17, 2010 at 01:43PM +0800, Américo Wang wrote:
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> BTW, I think we should add "use strict;" too.
Then I added "use strict;" to streamline_config.pl, I saw another
warings.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 286.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 287.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 288.
Then I added "my $dir;" to line 285.
Cc: Américo Wang <xiyou.wangcong@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Toralf Foerster <toralf.foerster@gmx.de>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hiromu Yakura <hiromu1996@gmail.com>
---
scripts/kconfig/streamline_config.pl | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/scripts/kconfig/streamline_config.pl
b/scripts/kconfig/streamline_config.pl
index d74363f..9ca361a 100644
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -42,6 +42,8 @@
# mv config_strip .config
# make oldconfig
#
+use strict;
+
my $config = ".config";
my $uname = `uname -r`;
@@ -280,6 +282,7 @@ if (defined($lsmod_file)) {
# see what modules are loaded on this system
my $lsmod;
+ my $dir;
foreach $dir ( ("/sbin", "/bin", "/usr/sbin", "/usr/bin") ) {
if ( -x "$dir/lsmod" ) {
--
1.7.0.4
next prev parent reply other threads:[~2010-08-17 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-15 4:13 hiromu yagura
2010-08-17 5:43 ` Américo Wang
2010-08-17 10:49 ` hiromu [this message]
2010-08-17 12:58 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282042158.7160.9.camel@hiromu-Macbook \
--to=hiromu1996@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=toralf.foerster@gmx.de \
--cc=xiyou.wangcong@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®