From: Peter Zijlstra <peterz@infradead.org>
To: Kusanagi Kouichi <slash@ac.auone-net.jp>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix build error on read only source.
Date: Wed, 18 Aug 2010 14:40:24 +0200 [thread overview]
Message-ID: <1282135224.1926.3936.camel@laptop> (raw)
In-Reply-To: <20100818123713.1F02414C03B@msa103.auone-net.jp>
On Wed, 2010-08-18 at 21:37 +0900, Kusanagi Kouichi wrote:
> With POSIX shell patch, $(OUTPUT) has not been created yet when it is
> used by try-cc. This fixes the issue anyway.
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index dcb9700..5b1c12b 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -281,6 +281,7 @@ endif
>
> -include feature-tests.mak
>
> +$(shell mkdir -p $(OUTPUT) 2> /dev/null)
> ifeq ($(call try-cc,$(SOURCE_HELLO),-Werror -fstack-protector-all),y)
> CFLAGS := $(CFLAGS) -fstack-protector-all
> endif
So you're wanting to provide a non-existing O=foo ?
I don't think we should, simply bail when it doesn't exist, kernel
builds do the same:
# make O=plop-build bzImage
/bin/sh: line 0: cd: plop-build: No such file or directory
Makefile:117: *** output directory "plop-build" does not exist. Stop.
next prev parent reply other threads:[~2010-08-18 12:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 18:18 Arnaldo Carvalho de Melo
2010-08-18 12:37 ` Kusanagi Kouichi
2010-08-18 12:40 ` Peter Zijlstra [this message]
2010-08-18 14:16 ` Arnaldo Carvalho de Melo
2010-08-18 14:27 ` Peter Zijlstra
2010-08-18 16:56 ` Arnaldo Carvalho de Melo
2010-08-18 17:01 ` Arnaldo Carvalho de Melo
2010-08-18 19:09 ` Arnaldo Carvalho de Melo
2010-08-19 9:02 ` Bernd Petrovitsch
2010-08-18 14:14 ` Arnaldo Carvalho de Melo
2010-08-18 15:25 ` Bernd Petrovitsch
2010-08-18 17:19 ` Arnaldo Carvalho de Melo
2010-08-19 10:31 ` Bernd Petrovitsch
2010-08-19 14:13 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2010-08-16 12:40 Kusanagi Kouichi
2010-08-16 15:24 ` Arnaldo Carvalho de Melo
2010-08-17 12:57 ` Kusanagi Kouichi
2010-08-17 14:08 ` Kusanagi Kouichi
2010-08-17 14:17 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282135224.1926.3936.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=slash@ac.auone-net.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®