From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751041Ab0HSAcj (ORCPT ); Wed, 18 Aug 2010 20:32:39 -0400 Received: from mga14.intel.com ([143.182.124.37]:30951 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793Ab0HSAch (ORCPT ); Wed, 18 Aug 2010 20:32:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.56,230,1280732400"; d="scan'208";a="314280929" Subject: Re: number of elements or bytes for kfifo_in etc From: Huang Ying To: Stefani Seibold Cc: Andrew Morton , "linux-kernel@vger.kernel.org" In-Reply-To: <1282149358.5103.5.camel@wall-e.seibold.net> References: <1282109365.2744.1549.camel@yhuang-dev> <1282149358.5103.5.camel@wall-e.seibold.net> Content-Type: text/plain; charset="UTF-8" Date: Thu, 19 Aug 2010 08:32:30 +0800 Message-ID: <1282177950.2744.1587.camel@yhuang-dev> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Stefani, On Thu, 2010-08-19 at 00:35 +0800, Stefani Seibold wrote: > Am Mittwoch, den 18.08.2010, 13:29 +0800 schrieb Huang Ying: > > Hi, Stefani, > > > > In new kfifo implementation in 2.6.36-rc1, description of the third > > parameter is: > > > > "@n: number of elements to be added" > > > > But if my understanding is correct, the actual implementation is: > > > > "@n: number of bytes to be added" > > > > Number of bytes is wrong, this is only valid for byte stream fifo's > where an element is a byte. > > Have a look at samples/kfifo/inttype-example.c where an element is a int > type. Yes. You are right. I misunderstood your code. Sorry for bothering. Best Regards, Huang Ying