From: Johannes Berg <johannes@sipsolutions.net>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel-doc: be case insensitive when removing attributes
Date: Thu, 19 Aug 2010 18:21:15 +0200 [thread overview]
Message-ID: <1282234875.4507.13.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100819085710.fe790810.rdunlap@xenotime.net>
On Thu, 2010-08-19 at 08:57 -0700, Randy Dunlap wrote:
> On Thu, 19 Aug 2010 16:13:42 +0200 Johannes Berg wrote:
>
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > There are valid attributes that could have upper
> > case letters, but we still want to remove, like
> > for example
> > __attribute__((aligned(NETDEV_ALIGN)))
> > as encountered in the wireless code.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > ---
> > I thought we did this before? Bit confused now :)
>
> I have a similar patch, without patch description & signoff,
> so maybe it was from irc. Oh, and it's in a different script location.
Oh, ok.
> @@ -1426,6 +1426,7 @@ sub dump_struct($$) {
> $members =~ s/kmemcheck_bitfield_.*?;//gos;
> # strip attributes
> $members =~ s/__aligned\s*\(\d+\)//gos;
> + $members =~ s/__attribute__\s*\(\([a-zA-Z,_()\s\*]*\)\)//gos;
>
>
> If yours (below) does what is needed, that's fine with me.
Yes, it removes the warning for me.
johannes
prev parent reply other threads:[~2010-08-19 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 14:13 Johannes Berg
2010-08-19 15:57 ` Randy Dunlap
2010-08-19 16:21 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282234875.4507.13.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®