From: Ian Campbell <ijc@hellion.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
stable-review@kernel.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk, Greg KH <gregkh@suse.de>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [2/3] mm: fix up some user-visible effects of the stack guard page
Date: Fri, 20 Aug 2010 17:32:54 +0100 [thread overview]
Message-ID: <1282321974.12544.24.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <AANLkTim1ABgiwscmaTZxeO9FxB4FacUNe0ahzUctQkn6@mail.gmail.com>
On Fri, 2010-08-20 at 09:07 -0700, Linus Torvalds wrote:
> Actually, thinking some more about it, that may not be a good idea.
> Why? Simply because we may want to merge the vma's back together if
> you do munlock. And it won't (and mustn't) merge if the vm_flags
> differ in VM_GROWSDOWN.
>
> So I do think we want to keep VM_GROWSDOWN (and VM_GROWSUP on PA-RISC)
> even across a vma split.
I naively hacked something together and it did seem to work, but I
shared your worries about merging.
> Of course, we could set a flag whether the vma really does have a
> guard page or not.
Bits in vma->vm_flags seems to be in rather short supply :-(
> That said, it does strike me as rather odd to do VM ops on partial
> stacks. What are you doing, exactly, to hit this?
I sent a contrived test program in my other mail.
The actual use is to mlock a buffer on the stack in order to pass it to
a Xen hypercall. The contract with the hypervisor is that the pages
passed to the hypercall must be mapped.
Ian.
--
Ian Campbell
Current Noise: Dinosaur Jr. - Green Mind
We can defeat gravity. The problem is the paperwork involved.
next prev parent reply other threads:[~2010-08-20 16:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 20:31 [0/3] 2.6.35.3 -stable review Greg KH
2010-08-18 20:30 ` [1/3] mm: fix page table unmap for stack guard page properly Greg KH
2010-08-18 20:30 ` [2/3] mm: fix up some user-visible effects of the stack guard page Greg KH
2010-08-20 12:54 ` Ian Campbell
2010-08-20 15:54 ` Linus Torvalds
2010-08-20 16:02 ` Ian Campbell
2010-08-20 16:07 ` Linus Torvalds
2010-08-20 16:24 ` Linus Torvalds
2010-08-20 17:43 ` Ian Campbell
2010-08-20 18:59 ` Linus Torvalds
2010-08-20 19:43 ` Linus Torvalds
2010-08-20 20:34 ` [Stable-review] " Willy Tarreau
2010-08-20 20:42 ` Peter Zijlstra
2010-08-20 21:17 ` Linus Torvalds
2010-08-20 21:24 ` Linus Torvalds
2010-08-23 8:58 ` Peter Zijlstra
2010-08-20 16:32 ` Ian Campbell [this message]
2010-08-20 16:35 ` Ian Campbell
2010-08-20 16:49 ` Linus Torvalds
2010-08-18 20:30 ` [3/3] vmware: fix build error in vmware.c Greg KH
2015-01-05 10:21 [2/3] mm: fix up some user-visible effects of the stack guard page Jay Foad
2015-01-05 21:03 ` Linus Torvalds
2015-01-05 21:11 ` Linus Torvalds
2015-01-05 21:19 ` Linus Torvalds
2015-01-06 13:27 ` Jay Foad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282321974.12544.24.camel@zakaz.uk.xensource.com \
--to=ijc@hellion.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®