Re: [PATCH] My work on MemoryStick system

[Maxim Levitsky <maximlevitsky@gmail.com>]

On Fri, 2010-08-20 at 03:15 +0300, Maxim Levitsky wrote: 
> Hi,
> 
> This patch series contains the work I did for memorystick subsystem.
> 
> I resend slightly cleaned up driver for my card reader in patch #2
> patch #1 and #3 are new and add support for Legacy MemorySticks (<= 128MB)
> 
> Everything works and more or less tested.
> 
> Best regards,
> 	Maxim Levitsky
> 
> 

I just tested this series with Jmicron, and unfortunelly there are bugs.

* driver refuses to handle 26 byte TPC I use to read regs
(sizeof(ms_registers). If I bump it to 32, it works.

* With this fix first few reads still fail.
That means that card isn't detected always because boot blocks might not
be read.
Later card works fine.

* Also I found out that msproblk.c allocates memory for attributes IO
using stock kmalloc, and hangs that to driver.
However if driver doesn't support such address, it will fail.
I fixed that in my driver by properly calling dma_unmap_sg, and thus
using SWIOTLB if necessary.
But Jmicron driver doesn't unmap its sg.
(Yet the system with Jmicron device has just one GB, so this isn't the
problem I am seeing).


Best regards,
Maxim Levitsky