From: Namhyung Kim <namhyung@gmail.com>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] h8300: fix a bug on get_user()
Date: Thu, 26 Aug 2010 19:52:45 +0900 [thread overview]
Message-ID: <1282819965-6025-1-git-send-email-namhyung@gmail.com> (raw)
current implementation of get_user() lacks parenthesis when it derefers ptr
so usage like get_user(val, addr + i) had a potential bug. Fix it.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
arch/h8300/include/asm/uaccess.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/h8300/include/asm/uaccess.h b/arch/h8300/include/asm/uaccess.h
index 356068c..b0e5cb9 100644
--- a/arch/h8300/include/asm/uaccess.h
+++ b/arch/h8300/include/asm/uaccess.h
@@ -91,7 +91,7 @@ extern int __put_user_bad(void);
#define get_user(x, ptr) \
({ \
int __gu_err = 0; \
- typeof(*(ptr)) __gu_val = *ptr; \
+ typeof(*(ptr)) __gu_val = *(ptr); \
switch (sizeof(*(ptr))) { \
case 1: \
case 2: \
--
1.7.2.2
reply other threads:[~2010-08-26 10:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282819965-6025-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®