From: Joe Perches <joe@perches.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Rotari Razvan-Gabriel <razvanrotari@gmail.com>,
clemens@ladisch.de, gregkh@suse.de, tj@kernel.org,
dbrownell@users.sourceforge.net, andre.goddard@gmail.com,
jkosina@suse.cz, davem@davemloft.net, shemminger@vyatta.com,
eric.dumazet@gmail.com, martin.petersen@oracle.com,
jens.axboe@oracle.com, linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: firewire: Fixed coding style for all the files in the directory
Date: Thu, 26 Aug 2010 08:41:11 -0700 [thread overview]
Message-ID: <1282837273.1875.60.camel@Joe-Laptop> (raw)
In-Reply-To: <4C758A00.5070203@s5r6.in-berlin.de>
On Wed, 2010-08-25 at 23:24 +0200, Stefan Richter wrote:
> Rotari Razvan-Gabriel wrote:
[]
> > +++ b/drivers/firewire/core-card.c
> > @@ -107,7 +107,7 @@ static void generate_config_rom(struct fw_card *card, __be32 *config_rom)
> > j = 7 + descriptor_count;
> >
> > /* Generate root directory entries for descriptors. */
> > - list_for_each_entry (desc, &descriptor_list, link) {
> > + list_for_each_entry(desc, &descriptor_list, link) {
> > if (desc->immediate > 0)
> > config_rom[i++] = cpu_to_be32(desc->immediate);
> > config_rom[i] = cpu_to_be32(desc->key | (j - i));
>
> Not a fix.
Perhaps you could consider it a consistency change for easier grepping
$ grep -rPoh --include=*.[ch] "\blist_for\w+\s*\(" drivers/firewire | sort | uniq -c
3 list_for_each_entry (
21 list_for_each_entry(
10 list_for_each_entry_safe(
prev parent reply other threads:[~2010-08-26 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 20:59 Rotari Razvan-Gabriel
2010-08-25 21:24 ` Stefan Richter
2010-08-25 21:31 ` Stefan Richter
2010-08-26 15:41 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282837273.1875.60.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=andre.goddard@gmail.com \
--cc=clemens@ladisch.de \
--cc=davem@davemloft.net \
--cc=dbrownell@users.sourceforge.net \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=martin.petersen@oracle.com \
--cc=razvanrotari@gmail.com \
--cc=shemminger@vyatta.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®