From: Namhyung Kim <namhyung@gmail.com>
To: Roland McGrath <roland@redhat.com>,
Oleg Nesterov <oleg@redhat.com>, Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, Mike Frysinger <vapier@gentoo.org>
Subject: [RFC PATCH 11/43] ptrace, blackfin: change signature of arch_ptrace()
Date: Fri, 27 Aug 2010 18:41:57 +0900 [thread overview]
Message-ID: <1282902149-12991-12-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <1282902149-12991-1-git-send-email-namhyung@gmail.com>
change type of @addr and @data into unsigned long according to commit
f76671df26ef06321480e702770f88f61272be29 [PATCH 03/43]
{get,put}_reg() also be changed because they are used only in
arch_ptrace() and this can make one of argument checking unnecessary.
And castings to void pointer can be removed by make use of datap.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Mike Frysinger <vapier@gentoo.org>
---
arch/blackfin/kernel/ptrace.c | 16 +++++++++-------
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/arch/blackfin/kernel/ptrace.c b/arch/blackfin/kernel/ptrace.c
index 6ec7768..545fc14 100644
--- a/arch/blackfin/kernel/ptrace.c
+++ b/arch/blackfin/kernel/ptrace.c
@@ -37,12 +37,13 @@
* Get contents of register REGNO in task TASK.
*/
static inline long
-get_reg(struct task_struct *task, long regno, unsigned long __user *datap)
+get_reg(struct task_struct *task, unsigned long regno,
+ unsigned long __user *datap)
{
long tmp;
struct pt_regs *regs = task_pt_regs(task);
- if (regno & 3 || regno > PT_LAST_PSEUDO || regno < 0)
+ if (regno & 3 || regno > PT_LAST_PSEUDO)
return -EIO;
switch (regno) {
@@ -73,11 +74,11 @@ get_reg(struct task_struct *task, long regno, unsigned long __user *datap)
* Write contents of register REGNO in task TASK.
*/
static inline int
-put_reg(struct task_struct *task, long regno, unsigned long data)
+put_reg(struct task_struct *task, unsigned long regno, unsigned long data)
{
struct pt_regs *regs = task_pt_regs(task);
- if (regno & 3 || regno > PT_LAST_PSEUDO || regno < 0)
+ if (regno & 3 || regno > PT_LAST_PSEUDO)
return -EIO;
switch (regno) {
@@ -232,7 +233,8 @@ void user_disable_single_step(struct task_struct *child)
clear_tsk_thread_flag(child, TIF_SINGLESTEP);
}
-long arch_ptrace(struct task_struct *child, long request, long addr, long data)
+long arch_ptrace(struct task_struct *child, long request,
+ unsigned long addr, unsigned long data)
{
int ret;
unsigned long __user *datap = (unsigned long __user *)data;
@@ -360,14 +362,14 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
return copy_regset_to_user(child, &user_bfin_native_view,
REGSET_GENERAL,
0, sizeof(struct pt_regs),
- (void __user *)data);
+ datap);
case PTRACE_SETREGS:
pr_debug("ptrace: PTRACE_SETREGS\n");
return copy_regset_from_user(child, &user_bfin_native_view,
REGSET_GENERAL,
0, sizeof(struct pt_regs),
- (const void __user *)data);
+ datap);
case_default:
default:
--
1.7.2.2
next prev parent reply other threads:[~2010-08-27 9:43 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 9:41 [RFC PATCH 00/43] ptrace cleanups Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 01/43] ptrace: change signature of sys_ptrace() and friends Namhyung Kim
2010-08-27 13:21 ` Arnd Bergmann
2010-08-27 15:55 ` Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 02/43] ptrace: cleanup ptrace_request() Namhyung Kim
2010-08-27 14:23 ` Arnd Bergmann
2010-08-27 16:13 ` Namhyung Kim
2010-08-27 19:26 ` Arnd Bergmann
2010-08-27 9:41 ` [RFC PATCH 03/43] ptrace: change signature of arch_ptrace() Namhyung Kim
2010-08-27 14:28 ` Arnd Bergmann
2010-08-27 16:20 ` Namhyung Kim
2010-08-29 13:40 ` Arnd Bergmann
2010-08-27 9:41 ` [RFC PATCH 04/43] ptrace, x86: " Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 05/43] ptrace, x86: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 06/43] ptrace, alpha: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 07/43] ptrace, arm: " Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 08/43] ptrace, arm: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 09/43] ptrace, avr32: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 10/43] ptrace, avr32: cleanup arch_ptrace() Namhyung Kim
2010-08-30 12:34 ` Haavard Skinnemoen
2010-08-27 9:41 ` Namhyung Kim [this message]
2010-08-27 9:41 ` [RFC PATCH 12/43] ptrace, cris-v10: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 13/43] ptrace, cris-v32: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 14/43] ptrace, frv: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 15/43] ptrace, frv: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 16/43] ptrace, h8300: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 17/43] ptrace, h8300: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 18/43] ptrace, ia64: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 19/43] ptrace, m32r: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 20/43] ptrace, m32r: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 21/43] ptrace, m68k: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 22/43] ptrace, m68k: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 23/43] ptrace, m68knommu: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 24/43] ptrace, m68knommu: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 25/43] ptrace, microblaze: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 26/43] ptrace, mips: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 27/43] ptrace, mips: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 28/43] ptrace, mn10300: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 29/43] ptrace, mn10300: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 30/43] ptrace, parisc: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 31/43] ptrace, powerpc: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 32/43] ptrace, powerpc: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 33/43] ptrace, s390: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 34/43] ptrace, score: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 35/43] ptrace, sh: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 36/43] ptrace, sh: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 37/43] ptrace, sparc: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 38/43] ptrace, sparc: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 39/43] ptrace, tile: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 40/43] ptrace, um: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 41/43] ptrace, um: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 42/43] ptrace, xtensa: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 43/43] ptrace, xtensa: cleanup arch_ptrace() Namhyung Kim
2010-08-27 11:01 ` [RFC PATCH 14/43] ptrace, frv: change signature of arch_ptrace() David Howells
2010-08-27 11:15 ` Namhyung Kim
2010-08-27 12:12 ` David Howells
2010-08-27 12:58 ` Namhyung Kim
2010-08-27 13:23 ` David Howells
2010-08-27 15:53 ` Namhyung Kim
2010-08-27 16:30 ` [RFC PATCH 00/43] ptrace cleanups Mike Frysinger
2010-08-30 0:14 ` Roland McGrath
2010-08-30 14:02 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282902149-12991-12-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®