mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: hch@infradead.org, viro@zeniv.linux.org.uk, adilger@sun.com,
	corbet@lwn.net, neilb@suse.de, npiggin@kernel.dk,
	hooanon05@yahoo.co.jp, bfields@fieldses.org, miklos@szeredi.hu
Cc: linux-fsdevel@vger.kernel.org, sfrench@us.ibm.com,
	philippe.deniel@CEA.FR, linux-kernel@vger.kernel.org,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH -V19 09/15] vfs: Add file access and modification time update via handle syscall
Date: Fri, 27 Aug 2010 16:32:56 +0530	[thread overview]
Message-ID: <1282906982-26918-10-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1282906982-26918-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 fs/compat.c              |   20 ++++++++++++++++++
 fs/utimes.c              |   49 ++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/syscalls.h |    3 ++
 include/linux/time.h     |    3 ++
 4 files changed, 75 insertions(+), 0 deletions(-)

diff --git a/fs/compat.c b/fs/compat.c
index c4037fd..29c4cb4 100644
--- a/fs/compat.c
+++ b/fs/compat.c
@@ -131,6 +131,26 @@ asmlinkage long compat_sys_utimes(const char __user *filename, struct compat_tim
 	return compat_sys_futimesat(AT_FDCWD, filename, t);
 }
 
+asmlinkage long compat_sys_handle_utimes(unsigned int mountdirfd,
+					 struct file_handle __user *ufh,
+					 struct compat_timeval __user *t)
+{
+	struct timespec tv[2];
+	if (t) {
+		if (get_user(tv[0].tv_sec, &t[0].tv_sec) ||
+		    get_user(tv[0].tv_nsec, &t[0].tv_usec) ||
+		    get_user(tv[1].tv_sec, &t[1].tv_sec) ||
+		    get_user(tv[1].tv_nsec, &t[1].tv_usec))
+			return -EFAULT;
+		if (tv[0].tv_nsec >= 1000000 || tv[0].tv_nsec < 0 ||
+		    tv[1].tv_nsec >= 1000000 || tv[1].tv_nsec < 0)
+			return -EINVAL;
+		tv[0].tv_nsec *= 1000;
+		tv[1].tv_nsec *= 1000;
+	}
+	return do_handle_utimes(mountdirfd, ufh, t ? tv : NULL);
+}
+
 static int cp_compat_stat(struct kstat *stat, struct compat_stat __user *ubuf)
 {
 	compat_ino_t ino = stat->ino;
diff --git a/fs/utimes.c b/fs/utimes.c
index 179b586..df241a1 100644
--- a/fs/utimes.c
+++ b/fs/utimes.c
@@ -222,3 +222,52 @@ SYSCALL_DEFINE2(utimes, char __user *, filename,
 {
 	return sys_futimesat(AT_FDCWD, filename, utimes);
 }
+
+long do_handle_utimes(int mountdirfd, struct file_handle __user *ufh,
+		      struct timespec *times)
+{
+	struct path path;
+	int error = -EINVAL;
+
+	if (times && (!nsec_valid(times[0].tv_nsec) ||
+		      !nsec_valid(times[1].tv_nsec))) {
+		goto out;
+	}
+	error = handle_to_path(mountdirfd, ufh, &path);
+	if (error)
+		goto out;
+
+	error = utimes_common(&path, times);
+	path_put(&path);
+out:
+	return error;
+}
+
+SYSCALL_DEFINE3(handle_utimes, int, mountdirfd,
+		struct file_handle __user *, ufh,
+		struct timeval __user *, utimes)
+{
+	struct timeval times[2];
+	struct timespec tstimes[2];
+
+	if (utimes) {
+		if (copy_from_user(&times, utimes, sizeof(times)))
+			return -EFAULT;
+
+		/* This test is needed to catch all invalid values.  If we
+		   would test only in do_utimes we would miss those invalid
+		   values truncated by the multiplication with 1000.  Note
+		   that we also catch UTIME_{NOW,OMIT} here which are only
+		   valid for utimensat.  */
+		if (times[0].tv_usec >= 1000000 || times[0].tv_usec < 0 ||
+		    times[1].tv_usec >= 1000000 || times[1].tv_usec < 0)
+			return -EINVAL;
+
+		tstimes[0].tv_sec = times[0].tv_sec;
+		tstimes[0].tv_nsec = 1000 * times[0].tv_usec;
+		tstimes[1].tv_sec = times[1].tv_sec;
+		tstimes[1].tv_nsec = 1000 * times[1].tv_usec;
+	}
+
+	return do_handle_utimes(mountdirfd, ufh, utimes ? tstimes : NULL);
+}
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 4c7e922..411a450 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -869,4 +869,7 @@ asmlinkage long sys_handle_listxattr(int mountdirfd,
 asmlinkage long sys_handle_removexattr(int mountdirfd,
 				       struct file_handle __user *ufh,
 				       const char __user *name);
+asmlinkage long sys_handle_utimes(int mountdirfd,
+				  struct file_handle __user *ufh,
+				  struct timeval __user *utimes);
 #endif
diff --git a/include/linux/time.h b/include/linux/time.h
index 9f15ac7..ce84274 100644
--- a/include/linux/time.h
+++ b/include/linux/time.h
@@ -151,6 +151,9 @@ extern int do_settimeofday(struct timespec *tv);
 extern int do_sys_settimeofday(struct timespec *tv, struct timezone *tz);
 #define do_posix_clock_monotonic_gettime(ts) ktime_get_ts(ts)
 extern long do_utimes(int dfd, const char __user *filename, struct timespec *times, int flags);
+struct file_handle;
+extern long do_handle_utimes(int mountdirfd, struct file_handle __user *ufh,
+			     struct timespec *times);
 struct itimerval;
 extern int do_setitimer(int which, struct itimerval *value,
 			struct itimerval *ovalue);
-- 
1.7.0.4


  parent reply	other threads:[~2010-08-27 11:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 11:02 [PATCH -V19 00/15] Generic name to handle and open by handle syscalls Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 01/15] exportfs: Return the minimum required handle size Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 02/15] vfs: Add name to file handle conversion support Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 03/15] vfs: Add open by file handle support Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 04/15] vfs: Add handle based readlink syscall Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 05/15] vfs: Add handle based stat syscall Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 06/15] vfs: Add handle based link syscall Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 07/15] vfs: Add handle based chown syscall Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 08/15] vfs: Add handle based xattr syscalls Aneesh Kumar K.V
2010-08-27 11:02 ` Aneesh Kumar K.V [this message]
2010-08-27 11:02 ` [PATCH -V19 10/15] x86: Add new syscalls for x86_32 Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 11/15] x86: Add new syscalls for x86_64 Aneesh Kumar K.V
2010-08-27 11:02 ` [PATCH -V19 12/15] unistd.h: Add new syscalls numbers to asm-generic Aneesh Kumar K.V
2010-08-27 11:03 ` [PATCH -V19 13/15] vfs: Export file system uuid via /proc/<pid>/mountinfo Aneesh Kumar K.V
2010-08-27 11:03 ` [PATCH -V19 14/15] ext3: Copy fs UUID to superblock Aneesh Kumar K.V
2010-08-27 11:03 ` [PATCH -V19 15/15] ext4: " Aneesh Kumar K.V
2010-09-07 10:21 ` [PATCH -V19 00/15] Generic name to handle and open by handle syscalls Aneesh Kumar K. V
2010-09-07 11:36   ` Miklos Szeredi
2010-09-07 12:59     ` Aneesh Kumar K. V
2010-09-07 13:24       ` Miklos Szeredi
2010-09-12 19:22         ` Aneesh Kumar K. V
2010-09-13  6:01           ` Miklos Szeredi
2010-09-13  6:59             ` Neil Brown
2010-09-13  7:59               ` Miklos Szeredi
2010-09-17 17:40             ` Aneesh Kumar K. V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282906982-26918-10-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=adilger@sun.com \
    --cc=bfields@fieldses.org \
    --cc=corbet@lwn.net \
    --cc=hch@infradead.org \
    --cc=hooanon05@yahoo.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=neilb@suse.de \
    --cc=npiggin@kernel.dk \
    --cc=philippe.deniel@CEA.FR \
    --cc=sfrench@us.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome