From: Eric Paris <eparis@redhat.com>
To: Csaba Henk <csaba@gluster.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] fsnotify: fix NULL dereference in send_to_group()
Date: Sat, 28 Aug 2010 17:19:57 -0400 [thread overview]
Message-ID: <1283030397.3284.133.camel@dhcp231-106.rdu.redhat.com> (raw)
In-Reply-To: <1283023542-1251-1-git-send-email-csaba@gluster.com>
On Sun, 2010-08-29 at 00:55 +0530, Csaba Henk wrote:
> If fanotify is triggered via a vfsmount mark (so that there is
> no inode mark, group in send_to_group() is set from a structure
> member where the struct pointer is NULL.
>
> This can be tested with the fanotify utility available from
> http://people.redhat.com/eparis/fanotify/:
>
> # fanotify -m / & touch /x
This should be fixed in the pull request I sent to Linus last night.
Sorry you had to track it down as well. There are a number of other bug
fixes in my tree
http://git.infradead.org/users/eparis/notify.git
There might still be some code duplication which something like 2/2
could clean up but your patch does apply to my devel tree and it has a
logic flaw. In the case we have both a vfsmount and an inode mark we
need to test:
event_mask & vmark->mask & ~vmark->ignored_mask & ~imark->ignored mask.
You would only ever test one or the other, not both together like that.
Thanks! Please let me know any other problems you run into!
-Eric
next prev parent reply other threads:[~2010-08-28 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 19:25 Csaba Henk
2010-08-28 19:25 ` [PATCH 2/2] fsnotify: refactor mask filtering " Csaba Henk
2010-08-28 21:19 ` Eric Paris [this message]
2010-08-28 21:50 ` [PATCH 1/2] fsnotify: fix NULL dereference " Csaba Henk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283030397.3284.133.camel@dhcp231-106.rdu.redhat.com \
--to=eparis@redhat.com \
--cc=csaba@gluster.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®