From: Steven Rostedt <rostedt@goodmis.org>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: TRACE: config warning for IRQSOFF_TRACER
Date: Mon, 30 Aug 2010 20:47:33 -0400 [thread overview]
Message-ID: <1283215653.1377.41.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1282402332.1978.32.camel@castor.rsk>
On Sat, 2010-08-21 at 15:52 +0100, Richard Kennedy wrote:
> In my config with PROVE_LOCKING=n and FTRACE=y (which defaults
> IRQSOFF_TRACER to y), I get the following warning from make oldconfig.
>
> scripts/kconfig/conf --oldconfig arch/x86/Kconfig
> warning: (IRQSOFF_TRACER && TRACING_SUPPORT && FTRACE &&
> TRACE_IRQFLAGS_SUPPORT && !ARCH_USES_GETTIMEOFFSET) selects
> TRACE_IRQFLAGS which has unmet direct dependencies (DEBUG_KERNEL &&
> TRACE_IRQFLAGS_SUPPORT && PROVE_LOCKING)
>
> The problem is that TRACE_IRQFLAGS depends on PROVE_LOCKING.
> Should it select PROVE_LOCKING instead? or is there a better way to fix
> this?
The TRACE_IRQFLAGS was originally written for lockdep, but it is now
used by Ftrace's irqsoff tracer.
I just compiled and booted with TRACE_IRQFLAGS=y and PROVE_LOCKING not
set, and it worked fine.
I think the correct patch is to remove the dependency of TRACE_IRQFLAGS
on PROVE_LOCKING.
-- Steve
prev parent reply other threads:[~2010-08-31 0:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 14:52 Richard Kennedy
2010-08-31 0:47 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283215653.1377.41.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®