From: Don Zickus <dzickus@redhat.com>
To: mingo@elte.hu
Cc: peterz@infradead.org, gorcunov@gmail.com, fweisbec@gmail.com,
linux-kernel@vger.kernel.org,
Akinobu Mita <akinobu.mita@gmail.com>,
Don Zickus <dzickus@redhat.com>
Subject: [PATCH 3/3] lockup_detector: remove unnecessary panic_notifier
Date: Tue, 31 Aug 2010 23:00:09 -0400 [thread overview]
Message-ID: <1283310009-22168-4-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1283310009-22168-1-git-send-email-dzickus@redhat.com>
From: Akinobu Mita <akinobu.mita@gmail.com>
The panic notifer in lockup_detector just set did_panic to 1.
But did_panic is not used anywhere so we can just remove it.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
kernel/watchdog.c | 15 ---------------
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index db70647..fa71aeb 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -43,7 +43,6 @@ static DEFINE_PER_CPU(unsigned long, hrtimer_interrupts_saved);
static DEFINE_PER_CPU(struct perf_event *, watchdog_ev);
#endif
-static int __read_mostly did_panic;
static int __initdata no_watchdog;
@@ -187,18 +186,6 @@ static int is_softlockup(unsigned long touch_ts)
return 0;
}
-static int
-watchdog_panic(struct notifier_block *this, unsigned long event, void *ptr)
-{
- did_panic = 1;
-
- return NOTIFY_DONE;
-}
-
-static struct notifier_block panic_block = {
- .notifier_call = watchdog_panic,
-};
-
#ifdef CONFIG_HARDLOCKUP_DETECTOR
static struct perf_event_attr wd_hw_attr = {
.type = PERF_TYPE_HARDWARE,
@@ -571,8 +558,6 @@ static int __init spawn_watchdog_task(void)
cpu_callback(&cpu_nfb, CPU_ONLINE, cpu);
register_cpu_notifier(&cpu_nfb);
- atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
-
return 0;
}
early_initcall(spawn_watchdog_task);
--
1.7.2.2
next prev parent reply other threads:[~2010-09-01 3:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 3:00 [PATCH 0/3] lockup detector fixes Don Zickus
2010-09-01 3:00 ` [PATCH 1/3] [lockup detector] sync touch_*_watchdog back to old semantics Don Zickus
2010-09-01 5:30 ` Ingo Molnar
2010-09-01 6:00 ` Cyrill Gorcunov
2010-09-01 7:01 ` Cyrill Gorcunov
2010-09-01 7:20 ` Ingo Molnar
2010-09-01 7:42 ` Cyrill Gorcunov
2010-09-01 9:19 ` [tip:perf/urgent] lockup_detector: Sync " tip-bot for Don Zickus
2010-09-01 3:00 ` [PATCH 2/3] lockup_detector: convert cpu notifier to return encapsulate errno value Don Zickus
2010-09-01 6:24 ` [tip:perf/core] lockup_detector: Convert " tip-bot for Akinobu Mita
2010-09-01 3:00 ` Don Zickus [this message]
2010-09-01 6:25 ` [tip:perf/core] lockup_detector: Remove unused panic_notifier tip-bot for Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283310009-22168-4-git-send-email-dzickus@redhat.com \
--to=dzickus@redhat.com \
--cc=akinobu.mita@gmail.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®