mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
To: "Quadros Roger (Nokia-MS/Helsinki)" <roger.quadros@nokia.com>
Cc: ext Andy Shevchenko <andy.shevchenko@gmail.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Hunter Adrian (Nokia-MS/Helsinki)" <adrian.hunter@nokia.com>
Subject: Re: [PATCH 2/3] mmc_test: change simple_strtol() to strict_strtol()
Date: Wed, 01 Sep 2010 11:43:25 +0300	[thread overview]
Message-ID: <1283330605.3117.12.camel@fs-test.research.nokia.com> (raw)
In-Reply-To: <4C7E0DFA.2090403@nokia.com>

On Wed, 2010-09-01 at 10:25 +0200, Quadros Roger (Nokia-MS/Helsinki)
wrote:

> No patch summary?
Will be in next version.

> > -static void mmc_test_run(struct mmc_test_card *test, int testcase)
> > +static void mmc_test_run(struct mmc_test_card *test, long testcase)
> >   {
> > -	int i, ret;
> > +	long i;
> 
> Why this change? isn't unsigned int sufficient for the mmc test cases?
You are right. This certain change is redundant. I'll skip it.

> > -	testcase = simple_strtol(buf, NULL, 10);
> > +	if (strict_strtol(buf, 10,&testcase))
> space required                    ^ here
It's odd. I have space in my patch.


-- 
With Best Regards,
Andy Shevchenko





  reply	other threads:[~2010-09-01  8:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01  6:26 [PATCH 0/3] mmc_test: show test results via sysfs Andy Shevchenko
2010-09-01  6:26 ` [PATCH 1/3] mmc_test: use API to check card type Andy Shevchenko
2010-09-01  6:26   ` [PATCH 2/3] mmc_test: change simple_strtol() to strict_strtol() Andy Shevchenko
2010-09-01  6:26     ` [PATCH 3/3] mmc_test: collect data and show it via sysfs by demand Andy Shevchenko
2010-09-01  8:25     ` [PATCH 2/3] mmc_test: change simple_strtol() to strict_strtol() Roger Quadros
2010-09-01  8:43       ` Andy Shevchenko [this message]
2010-09-01 21:46 ` [PATCH 0/3] mmc_test: show test results via sysfs Chris Ball
2010-09-01 23:30   ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283330605.3117.12.camel@fs-test.research.nokia.com \
    --to=ext-andriy.shevchenko@nokia.com \
    --cc=adrian.hunter@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=roger.quadros@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®