From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753286Ab0IBOZY (ORCPT ); Thu, 2 Sep 2010 10:25:24 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:48213 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658Ab0IBOZW (ORCPT ); Thu, 2 Sep 2010 10:25:22 -0400 X-Authority-Analysis: v=1.1 cv=F68j8apdn+AYvba2s2WjKYIAmW276Pjvg9wPu/ZwFig= c=1 sm=0 a=h6dlIqBDnR0A:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=JTc0kuPUaKgL5iNhwmUA:9 a=GXRP4dHX9Da4qdmMYgUNNuscQ28A:4 a=PUjeQqilurYA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: kernelshark plugins and ftrace array fields From: Steven Rostedt To: Avi Kivity Cc: linux-kernel , KVM list In-Reply-To: <4C7F9639.7000804@redhat.com> References: <4C7F9639.7000804@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Date: Thu, 02 Sep 2010 10:25:21 -0400 Message-ID: <1283437521.2356.136.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2010-09-02 at 15:19 +0300, Avi Kivity wrote: > I'd like to add enhance kvm_emulate_insn display in kernelshark to > show the disassembly of the instruction being emulated. However, > pevent_get_field_val() doesn't support arrays (the instruction is > provided in a 15-byte array). > > Can you add support for arrays in the kernelshark API? With that, it > looks like adding disassembly output to the kvm plugin should be quite > simple. > Sure, I could add a pevent_get_field_array() or something. Could you tell me the event and give me an example of what you want to do. Thanks, -- Steve