From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 3/3] KVM: SVM: Clean up rip handling in vmrun emulation
Date: Thu, 2 Sep 2010 17:29:47 +0200 [thread overview]
Message-ID: <1283441387-7378-4-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1283441387-7378-1-git-send-email-joerg.roedel@amd.com>
This patch changes the rip handling in the vmrun emulation
path from using next_rip to the generic kvm register access
functions.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/kvm/svm.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index ecd4e58..1643f30 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -2069,7 +2069,7 @@ static bool nested_svm_vmrun(struct vcpu_svm *svm)
return false;
}
- trace_kvm_nested_vmrun(svm->vmcb->save.rip - 3, vmcb_gpa,
+ trace_kvm_nested_vmrun(svm->vmcb->save.rip, vmcb_gpa,
nested_vmcb->save.rip,
nested_vmcb->control.int_ctl,
nested_vmcb->control.event_inj,
@@ -2270,8 +2270,8 @@ static int vmrun_interception(struct vcpu_svm *svm)
if (nested_svm_check_permissions(svm))
return 1;
- svm->next_rip = kvm_rip_read(&svm->vcpu) + 3;
- skip_emulated_instruction(&svm->vcpu);
+ /* Save rip after vmrun instruction */
+ kvm_rip_write(&svm->vcpu, kvm_rip_read(&svm->vcpu) + 3);
if (!nested_svm_vmrun(svm))
return 1;
--
1.7.0.4
next prev parent reply other threads:[~2010-09-02 15:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 15:29 [PATCH 0/3] KVM fixes and cleanups Joerg Roedel
2010-09-02 15:29 ` [PATCH 1/3] KVM: MMU: Fix 32 bit legacy paging with NPT Joerg Roedel
2010-09-02 15:56 ` Avi Kivity
2010-09-02 16:32 ` Roedel, Joerg
2010-09-02 15:29 ` [PATCH 2/3] KVM: SVM: Restore correct registers after sel_cr0 intercept emulation Joerg Roedel
2010-09-02 16:02 ` Avi Kivity
2010-09-02 16:29 ` Roedel, Joerg
2010-09-05 7:09 ` Avi Kivity
2010-09-02 15:29 ` Joerg Roedel [this message]
2010-09-03 12:21 ` [PATCH 3/3] KVM: SVM: Clean up rip handling in vmrun emulation Roedel, Joerg
2010-09-03 21:29 ` Alexander Graf
2010-09-04 19:32 ` Joerg Roedel
2010-09-06 18:26 ` [PATCH 0/3] KVM fixes and cleanups Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283441387-7378-4-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®