From: Namhyung Kim <namhyung@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ida: fix up bitmap size calculation
Date: Fri, 3 Sep 2010 02:00:29 +0900 [thread overview]
Message-ID: <1283446829-24050-1-git-send-email-namhyung@gmail.com> (raw)
ida chunk should consist of 128 bytes (= 1024 bits) by definition
but because of wrong calculation of IDA_BITMAP_LONGS it only contained
992 on 32-bit machines, 960 on 64-bit machines. Fix it.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
include/linux/idr.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/idr.h b/include/linux/idr.h
index e968db7..13c7296 100644
--- a/include/linux/idr.h
+++ b/include/linux/idr.h
@@ -119,8 +119,8 @@ void idr_init(struct idr *idp);
* pointer isn't necessary.
*/
#define IDA_CHUNK_SIZE 128 /* 128 bytes per chunk */
-#define IDA_BITMAP_LONGS (128 / sizeof(long) - 1)
-#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8)
+#define IDA_BITMAP_LONGS (IDA_CHUNK_SIZE / sizeof(long))
+#define IDA_BITMAP_BITS (IDA_CHUNK_SIZE * 8)
struct ida_bitmap {
long nr_busy;
--
1.7.2.2
next reply other threads:[~2010-09-02 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 17:00 Namhyung Kim [this message]
2010-09-02 17:20 ` Tejun Heo
2010-09-02 17:25 ` Namhyung Kim
2010-09-02 18:07 ` Namhyung Kim
2010-09-03 9:14 ` Tejun Heo
2010-09-03 9:26 ` Namhyung Kim
2010-09-03 9:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283446829-24050-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®