From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: trivial@kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] include/net/raw.h: Convert raw_seq_private macro to inline
Date: Mon, 06 Sep 2010 22:01:17 -0700 [thread overview]
Message-ID: <1283835677.23280.108.camel@Joe-Laptop> (raw)
In-Reply-To: <20100906.184749.214227378.davem@davemloft.net>
On Mon, 2010-09-06 at 18:47 -0700, David Miller wrote:
> raw_seq_private() expands to something which dereferences the pointer,
> which you've now made void, which is illegal and breaks the build.
> Reverted.
Apologies, I had this in my tree which I didn't send
because it wasn't a private_data cast removal.
Signed-off-by: Joe Perches <joe@perches.com>
---
include/net/raw.h | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/net/raw.h b/include/net/raw.h
index 43c5750..c621200 100644
--- a/include/net/raw.h
+++ b/include/net/raw.h
@@ -45,7 +45,10 @@ struct raw_iter_state {
struct raw_hashinfo *h;
};
-#define raw_seq_private(seq) ((struct raw_iter_state *)(seq)->private)
+inline struct raw_iter_state *raw_seq_private(struct seq_file *seq)
+{
+ return seq->private;
+}
void *raw_seq_start(struct seq_file *seq, loff_t *pos);
void *raw_seq_next(struct seq_file *seq, void *v, loff_t *pos);
void raw_seq_stop(struct seq_file *seq, void *v);
next prev parent reply other threads:[~2010-09-07 5:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1283650107.git.joe@perches.com>
2010-09-05 1:52 ` [PATCH 01/13] drivers/gpu/drm: Remove unnecessary casts of private_data Joe Perches
2010-09-23 11:36 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 02/13] drivers/infiniband: " Joe Perches
2010-09-07 18:24 ` Ralph Campbell
2010-09-23 11:38 ` Jiri Kosina
2010-10-06 21:44 ` Roland Dreier
2010-09-05 1:52 ` [PATCH 03/13] drivers/net/wireless/iwlwifi: " Joe Perches
2010-09-05 1:52 ` [PATCH 04/13] drivers/s390: " Joe Perches
2010-09-23 11:42 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 05/13] drivers/scsi: " Joe Perches
2010-09-23 11:45 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 06/13] drivers/staging/lirc: " Joe Perches
2010-09-05 1:52 ` [PATCH 07/13] fs/ecryptfs: " Joe Perches
2010-09-23 11:31 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 08/13] fs/seq_file.c: " Joe Perches
2010-09-23 11:29 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 09/13] kernel/pm_qos_params.c: " Joe Perches
2010-09-23 11:34 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 10/13] kernel/trace: " Joe Perches
2010-09-23 11:37 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 11/13] net/ipv4: " Joe Perches
2010-09-07 1:30 ` David Miller
2010-09-07 1:47 ` David Miller
2010-09-07 5:01 ` Joe Perches [this message]
2010-09-07 15:37 ` [PATCH net-next] include/net/raw.h: Convert raw_seq_private macro to inline Nick Bowler
2010-09-07 15:55 ` [PATCH V2 " Joe Perches
2010-09-08 20:42 ` David Miller
2010-09-05 1:52 ` [PATCH 12/13] net/sunrpc/rpc_pipe.c: Remove unnecessary casts of private_data Joe Perches
2010-09-23 11:40 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 13/13] sound: " Joe Perches
2010-09-07 6:10 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283835677.23280.108.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=trivial@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome