mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gary King <gking@nvidia.com>
To: linux-mm@kvack.org
Cc: linux-arm-kernel@lists.infradead.org, tj@kernel.org,
	linux-kernel@vger.kernel.org, Gary King <gking@nvidia.com>
Subject: [PATCH] bounce: call flush_dcache_page after bounce_copy_vec
Date: Tue,  7 Sep 2010 13:45:34 -0700	[thread overview]
Message-ID: <1283892334-9238-1-git-send-email-gking@nvidia.com> (raw)

I have been seeing problems on Tegra 2 (ARMv7 SMP) systems with HIGHMEM
enabled on 2.6.35 (plus some patches targetted at 2.6.36 to perform
cache maintenance lazily), and the root cause appears to be that the
mm bouncing code is calling flush_dcache_page before it copies the
bounce buffer into the bio.

The patch below reorders these two operations, and eliminates numerous
arbitrary application crashes on my dev system.

Gary

--
>From 678c9bca8d8a8f254f28af91e69fad3aa1be7593 Mon Sep 17 00:00:00 2001
From: Gary King <gking@nvidia.com>
Date: Mon, 6 Sep 2010 15:37:12 -0700
Subject: bounce: call flush_dcache_page after bounce_copy_vec

the bounced page needs to be flushed after data is copied into it,
to ensure that architecture implementations can synchronize
instruction and data caches if necessary.

Signed-off-by: Gary King <gking@nvidia.com>
---
 mm/bounce.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/bounce.c b/mm/bounce.c
index 13b6dad..1481de6 100644
--- a/mm/bounce.c
+++ b/mm/bounce.c
@@ -116,8 +116,8 @@ static void copy_to_high_bio_irq(struct bio *to, struct bio *from)
 		 */
 		vfrom = page_address(fromvec->bv_page) + tovec->bv_offset;
 
-		flush_dcache_page(tovec->bv_page);
 		bounce_copy_vec(tovec, vfrom);
+		flush_dcache_page(tovec->bv_page);
 	}
 }
 
-- 
1.7.0.4


             reply	other threads:[~2010-09-07 20:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-07 20:45 Gary King [this message]
2010-09-08 19:47 ` Andrew Morton
2010-09-08 19:49   ` Jens Axboe
2010-09-09  0:49 ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283892334-9238-1-git-send-email-gking@nvidia.com \
    --to=gking@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome