From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbcF0PpF (ORCPT ); Mon, 27 Jun 2016 11:45:05 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:35091 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbcF0PpC convert rfc822-to-8bit (ORCPT ); Mon, 27 Jun 2016 11:45:02 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: linux-next: build failure after merge of the nfs tree From: Trond Myklebust In-Reply-To: <20160627105839.763d6d22@canb.auug.org.au> Date: Mon, 27 Jun 2016 11:44:45 -0400 Cc: List Linux Next Mailing , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <12838D4D-17A4-4D7B-B7C7-702D5DDB888E@gmail.com> References: <20160627105839.763d6d22@canb.auug.org.au> To: Stephen Rothwell X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jun 26, 2016, at 20:58, Stephen Rothwell wrote: > > Hi Trond, > > After merging the nfs tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > fs/nfs/pnfs_nfs.c: In function 'pnfs_nfs_generic_sync': > fs/nfs/pnfs_nfs.c:947:8: error: too few arguments to function 'nfs_commit_inode' > ret = nfs_commit_inode(inode); > ^ > In file included from fs/nfs/pnfs_nfs.c:10:0: > include/linux/nfs_fs.h:509:13: note: declared here > extern int nfs_commit_inode(struct inode *, int); > ^ > > Caused by commit > > 292cc573fce6 ("pNFS: Files and flexfiles always need to commit before layoutcommit") > > I have used the nsf tree from next-20160624 for today > Hi Stephen, My apologies: That was a last minute typo when amending a commit. I’ve fixed the code in today’s linux-next branch. Cheers Trond