From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 19/29] KVM: X86: Propagate fetch faults
Date: Fri, 10 Sep 2010 17:30:56 +0200 [thread overview]
Message-ID: <1284132667-18620-20-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1284132667-18620-1-git-send-email-joerg.roedel@amd.com>
KVM currently ignores fetch faults in the instruction
emulator. With nested-npt we could have such faults. This
patch adds the code to handle these.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/kvm/emulate.c | 3 +++
arch/x86/kvm/x86.c | 4 ++++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 2b08b78..aead72e 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -1198,6 +1198,9 @@ static int emulate_popf(struct x86_emulate_ctxt *ctxt,
*(unsigned long *)dest =
(ctxt->eflags & ~change_mask) | (val & change_mask);
+ if (rc == X86EMUL_PROPAGATE_FAULT)
+ emulate_pf(ctxt);
+
return rc;
}
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 2816e5a..16c044b 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4233,6 +4233,9 @@ int emulate_instruction(struct kvm_vcpu *vcpu,
vcpu->arch.emulate_ctxt.perm_ok = false;
r = x86_decode_insn(&vcpu->arch.emulate_ctxt);
+ if (r == X86EMUL_PROPAGATE_FAULT)
+ goto done;
+
trace_kvm_emulate_insn_start(vcpu);
/* Only allow emulation of specific instructions on #UD
@@ -4291,6 +4294,7 @@ restart:
return handle_emulation_failure(vcpu);
}
+done:
if (vcpu->arch.emulate_ctxt.exception >= 0) {
inject_emulated_exception(vcpu);
r = EMULATE_DONE;
--
1.7.0.4
next prev parent reply other threads:[~2010-09-10 15:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 15:30 [PATCH 0/29] Nested Paging Virtualization for KVM v4 Joerg Roedel
2010-09-10 15:30 ` [PATCH 01/29] KVM: MMU: Check for root_level instead of long mode Joerg Roedel
2010-09-10 15:30 ` [PATCH 02/29] KVM: MMU: Make tdp_enabled a mmu-context parameter Joerg Roedel
2010-09-10 15:30 ` [PATCH 03/29] KVM: MMU: Make set_cr3 a function pointer in kvm_mmu Joerg Roedel
2010-09-10 15:30 ` [PATCH 04/29] KVM: X86: Introduce a tdp_set_cr3 function Joerg Roedel
2010-09-10 15:30 ` [PATCH 05/29] KVM: MMU: Introduce get_cr3 function pointer Joerg Roedel
2010-09-10 15:30 ` [PATCH 06/29] KVM: MMU: Introduce inject_page_fault " Joerg Roedel
2010-09-10 15:30 ` [PATCH 07/29] KVM: MMU: Introduce kvm_init_shadow_mmu helper function Joerg Roedel
2010-09-10 15:30 ` [PATCH 08/29] KVM: MMU: Let is_rsvd_bits_set take mmu context instead of vcpu Joerg Roedel
2010-09-10 15:30 ` [PATCH 09/29] KVM: MMU: Track page fault data in struct vcpu Joerg Roedel
2010-09-10 15:30 ` [PATCH 10/29] KVM: MMU: Introduce generic walk_addr function Joerg Roedel
2010-09-10 15:30 ` [PATCH 11/29] KVM: MMU: Add infrastructure for two-level page walker Joerg Roedel
2010-09-10 15:30 ` [PATCH 12/29] KVM: X86: Introduce pointer to mmu context used for gva_to_gpa Joerg Roedel
2010-09-10 15:30 ` [PATCH 13/29] KVM: MMU: Implement nested gva_to_gpa functions Joerg Roedel
2010-09-10 15:30 ` [PATCH 14/29] KVM: X86: Add kvm_read_guest_page_mmu function Joerg Roedel
2010-09-10 15:30 ` [PATCH 15/29] KVM: MMU: Make walk_addr_generic capable for two-level walking Joerg Roedel
2010-09-10 15:30 ` [PATCH 16/29] KVM: MMU: Introduce kvm_read_nested_guest_page() Joerg Roedel
2010-09-10 15:30 ` [PATCH 17/29] KVM: MMU: Introduce init_kvm_nested_mmu() Joerg Roedel
2010-09-10 15:30 ` [PATCH 18/29] KVM: MMU: Propagate the right fault back to the guest after gva_to_gpa Joerg Roedel
2010-09-12 8:50 ` Avi Kivity
2010-09-10 15:30 ` Joerg Roedel [this message]
2010-09-10 15:30 ` [PATCH 20/29] KVM: MMU: Add kvm_mmu parameter to load_pdptrs function Joerg Roedel
2010-09-10 15:30 ` [PATCH 21/29] KVM: MMU: Introduce kvm_pdptr_read_mmu Joerg Roedel
2010-09-10 15:30 ` [PATCH 22/29] KVM: MMU: Refactor mmu_alloc_roots function Joerg Roedel
2010-09-10 15:31 ` [PATCH 23/29] KVM: MMU: Allow long mode shadows for legacy page tables Joerg Roedel
2010-09-10 15:31 ` [PATCH 24/29] KVM: MMU: Track NX state in struct kvm_mmu Joerg Roedel
2010-09-12 8:06 ` Avi Kivity
2010-09-10 15:31 ` [PATCH 25/29] KVM: SVM: Implement MMU helper functions for Nested Nested Paging Joerg Roedel
2010-09-10 15:31 ` [PATCH 26/29] KVM: SVM: Initialize Nested Nested MMU context on VMRUN Joerg Roedel
2010-09-10 15:31 ` [PATCH 27/29] KVM: SVM: Expect two more candiates for exit_int_info Joerg Roedel
2010-09-10 15:31 ` [PATCH 28/29] KVM: SVM: Report Nested Paging support to userspace Joerg Roedel
2010-09-10 15:31 ` [PATCH 29/29] KVM: X86: Report SVM bit to userspace only when supported Joerg Roedel
2010-09-12 8:56 ` [PATCH 0/29] Nested Paging Virtualization for KVM v4 Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284132667-18620-20-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®