From: Mike Galbraith <efault@gmx.de>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [RFC patch 1/2] sched: dynamically adapt granularity with nr_running
Date: Mon, 13 Sep 2010 06:13:03 +0200 [thread overview]
Message-ID: <1284351183.7321.36.camel@marge.simson.net> (raw)
In-Reply-To: <20100912181626.GB32327@Krystal>
On Sun, 2010-09-12 at 14:16 -0400, Mathieu Desnoyers wrote:
> * Mike Galbraith (efault@gmx.de) wrote:
> > On Sun, 2010-09-12 at 08:14 +0200, Ingo Molnar wrote:
> > > * Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> > >
> > > > (on a uniprocessor 2.0 GHz Pentium M)
> > > >
> > > > * Without the patch:
> > > >
> > > > - wakeup-latency with SIGEV_THREAD in parallel with youtube video and
> > > > make -j10
> > > >
> > > > maximum latency: 50107.8 µs
> > > > average latency: 6609.2 µs
> > > > missed timer events: 0
> > >
> > > I tried your patches on a similar UP system, using wakeup-latency.c. I
> > > also measured the vanilla upstream kernel (cced86a) with the default
> > > granularity settings, and also vanilla with a sched_min_granularity/3
> > > tune (patch attached below for that).
> > >
> > > I got the following results (make -j10 kbuild load, average of 3 runs):
> > >
> > > vanilla:
> > >
> > > maximum latency: 38278.9 µs
> > > average latency: 7730.1 µs
> > >
> > > mathieu-dyn:
> > >
> > > maximum latency: 28698.8 µs
> > > average latency: 7757.1 µs
> > >
> > > peterz-min_gran/3:
> > >
> > > maximum latency: 22702.1 µs
> > > average latency: 6684.8 µs
> >
> > One thing that springs to mind with make is that it does vfork, so kinda
> > sorta continues running in drag, so shouldn't get credit for sleeping,
> > as that introduces bogus spread. Post vfork parent notification time
> > adjustment may suffice, think I'll try that.
>
> Hrm, I might be misunderstanding what you are saying here, but when a new
> process/thread is forked and woken up, we fall in the "initial" case of
> place_entity, so we increase the vruntime of a whole slice rather than getting
> credit for sleeping.
>
> Or am I missing your point ?
Yes and no. I'm pondering the parent, but by the same token, the vfork
child shouldn't be penalized either.
Does your latency go down drastically if you turn START_DEBIT off?
Seems like it should. Perhaps START_DEBIT should not start a task
further right than rightmost. I've done that before.
maximum latency: 19221.5 µs
average latency: 5159.0 µs
missed timer events: 0
maximum latency: 43901.0 µs
average latency: 8430.1 µs
missed timer events: 0
Turning it off here cut latency roughly in half (i've piddled vfork
though, but not completely). Limiting child placement to no further
right than rightmost should help quite a bit.
-Mike
next prev parent reply other threads:[~2010-09-13 4:12 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 17:37 [RFC patch 0/2] " Mathieu Desnoyers
2010-09-11 17:37 ` [RFC patch 1/2] " Mathieu Desnoyers
2010-09-11 18:57 ` Peter Zijlstra
2010-09-11 19:21 ` Linus Torvalds
2010-09-11 20:36 ` Peter Zijlstra
2010-09-11 20:45 ` Peter Zijlstra
2010-09-11 20:52 ` Linus Torvalds
2010-09-12 9:07 ` Peter Zijlstra
2010-09-11 20:48 ` Linus Torvalds
2010-09-12 9:06 ` Peter Zijlstra
2010-09-12 9:14 ` Peter Zijlstra
2010-09-12 20:39 ` Mathieu Desnoyers
2010-09-13 12:54 ` Peter Zijlstra
2010-09-12 20:34 ` Mathieu Desnoyers
2010-09-13 12:53 ` Peter Zijlstra
2010-09-13 4:35 ` Mike Galbraith
2010-09-13 8:41 ` Peter Zijlstra
2010-09-13 11:22 ` Ingo Molnar
2010-09-13 13:52 ` Steven Rostedt
2010-09-13 13:54 ` Peter Zijlstra
2010-09-13 14:02 ` Peter Zijlstra
2010-09-13 14:21 ` Ingo Molnar
2010-09-11 20:52 ` Mathieu Desnoyers
2010-09-11 19:57 ` Mathieu Desnoyers
2010-09-12 10:41 ` Peter Zijlstra
2010-09-12 20:37 ` Mathieu Desnoyers
2010-09-13 12:53 ` Peter Zijlstra
2010-09-13 13:15 ` Peter Zijlstra
2010-09-13 13:56 ` Mathieu Desnoyers
2010-09-13 14:16 ` Peter Zijlstra
2010-09-13 14:43 ` Steven Rostedt
2010-09-13 15:25 ` Mathieu Desnoyers
2010-09-13 15:39 ` Steven Rostedt
2010-09-13 16:16 ` [RFC PATCH] check_preempt_tick should not compare vruntime with wall time Mathieu Desnoyers
2010-09-13 16:36 ` Linus Torvalds
2010-09-13 17:45 ` Mathieu Desnoyers
2010-09-13 17:51 ` Linus Torvalds
2010-09-13 18:01 ` Mathieu Desnoyers
2010-09-13 18:10 ` Steven Rostedt
2010-09-13 18:03 ` Ingo Molnar
2010-09-13 18:19 ` Mathieu Desnoyers
2010-09-13 18:23 ` [PATCH] sched: Improve latencies under load by decreasing minimum scheduling granularity Ingo Molnar
2010-09-13 18:28 ` Joe Perches
2010-09-13 19:44 ` Linus Torvalds
2010-09-13 20:00 ` Ingo Molnar
2010-09-13 18:19 ` [RFC PATCH] check_preempt_tick should not compare vruntime with wall time Ingo Molnar
2010-09-13 17:36 ` Ingo Molnar
2010-09-13 17:56 ` Mathieu Desnoyers
2010-09-14 2:10 ` Mike Galbraith
2010-09-13 14:44 ` [RFC patch 1/2] sched: dynamically adapt granularity with nr_running Mike Galbraith
[not found] ` <1284386179.10436.6.camel@marge.simson.net>
2010-09-13 15:53 ` Peter Zijlstra
2010-09-13 18:04 ` [RFC][PATCH] sched: Improve tick preemption Peter Zijlstra
2010-09-14 2:27 ` [RFC patch 1/2] sched: dynamically adapt granularity with nr_running Mike Galbraith
2010-09-12 6:14 ` Ingo Molnar
2010-09-12 7:21 ` Mike Galbraith
2010-09-12 18:16 ` Mathieu Desnoyers
2010-09-13 4:13 ` Mike Galbraith [this message]
2010-09-13 6:41 ` Ingo Molnar
2010-09-13 7:08 ` Mike Galbraith
2010-09-13 7:35 ` Mike Galbraith
2010-09-13 8:35 ` Peter Zijlstra
2010-09-13 9:16 ` Mike Galbraith
2010-09-13 9:37 ` Peter Zijlstra
2010-09-13 9:50 ` Mike Galbraith
2010-09-13 9:55 ` Peter Zijlstra
2010-09-13 10:06 ` Mike Galbraith
2010-09-13 10:45 ` Peter Zijlstra
2010-09-13 11:43 ` Peter Zijlstra
2010-09-13 11:49 ` Peter Zijlstra
2010-09-13 12:32 ` Mike Galbraith
2010-09-13 20:19 ` Mathieu Desnoyers
2010-09-13 20:56 ` Mathieu Desnoyers
2010-09-12 18:13 ` Mathieu Desnoyers
2010-09-12 23:44 ` Mathieu Desnoyers
2010-09-11 17:37 ` [RFC patch 2/2] sched: sleepers coarse granularity on wakeup Mathieu Desnoyers
2010-09-12 12:44 ` [RFC patch 0/2] sched: dynamically adapt granularity with nr_running Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284351183.7321.36.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome