From: florian@mickler.org
To: x86@kernel.org
Cc: Florian Mickler <florian@mickler.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Russell King <linux@arm.linux.org.uk>,
Mike Frysinger <vapier@gentoo.org>,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH] x86: don't compile with gcc-3.3.3
Date: Mon, 13 Sep 2010 10:31:47 +0200 [thread overview]
Message-ID: <1284366708-30154-1-git-send-email-florian@mickler.org> (raw)
hpa commented on bug 16506[1] :
"Please note that gcc-3.3.3 is known broken on x86; gcc-3.4 is the oldest
version which is known to *not* be broken."
References:
[0]: https://bugzilla.kernel.org/show_bug.cgi?id=16633
[1]: https://bugzilla.kernel.org/show_bug.cgi?id=16506#c28
If that is indeed so, we should abort the build? No?
---
arch/x86/Makefile | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 8aa1b59..1eb2d99 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -153,7 +153,7 @@ all: bzImage
# KBUILD_IMAGE specify target image being built
KBUILD_IMAGE := $(boot)/bzImage
-bzImage: vmlinux
+bzImage: checkgccversion vmlinux
ifeq ($(CONFIG_X86_DECODER_SELFTEST),y)
$(Q)$(MAKE) $(build)=arch/x86/tools posttest
endif
@@ -172,6 +172,12 @@ PHONY += vdso_install
vdso_install:
$(Q)$(MAKE) $(build)=arch/x86/vdso $@
+checkgccversion:
+ $(Q)if test "$(call cc-fullversion)" = "040403" ; then \
+ echo "*** GCC-3.3.3 is known broken. Please upgrade." ; \
+ echo "*** GCC-3.4 is the earliest version known *not* broken." ; \
+ false ; \
+ fi
archclean:
$(Q)rm -rf $(objtree)/arch/i386
$(Q)rm -rf $(objtree)/arch/x86_64
--
1.7.2
next reply other threads:[~2010-09-13 8:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 8:31 florian [this message]
2010-09-13 8:39 ` Peter Zijlstra
2010-09-13 15:56 ` H. Peter Anvin
2010-09-13 16:21 ` Florian Mickler
2010-09-13 16:28 ` Florian Mickler
2010-09-13 17:25 ` H. Peter Anvin
2010-09-13 18:42 ` Florian Mickler
2010-09-13 20:00 ` H. Peter Anvin
2010-09-13 20:03 ` Florian Mickler
2010-09-13 16:33 ` Russell King - ARM Linux
2010-09-13 17:26 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284366708-30154-1-git-send-email-florian@mickler.org \
--to=florian@mickler.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®