From: Namhyung Kim <namhyung@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Darren Hart <dvhltc@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] futex: change signature of fetch_robust_entry()
Date: Tue, 14 Sep 2010 21:43:46 +0900 [thread overview]
Message-ID: <1284468228-8723-1-git-send-email-namhyung@gmail.com> (raw)
Make 3rd argument of fetch_robust_entry() 'unsigned int' in order to
remove following warnings from sparse:
kernel/futex.c:2495:59: warning: incorrect type in argument 3 (different signedness)
kernel/futex.c:2495:59: expected int *pi
kernel/futex.c:2495:59: got unsigned int *<noident>
kernel/futex.c:2506:67: warning: incorrect type in argument 3 (different signedness)
kernel/futex.c:2506:67: expected int *pi
kernel/futex.c:2506:67: got unsigned int *<noident>
kernel/futex.c:2515:69: warning: incorrect type in argument 3 (different signedness)
kernel/futex.c:2515:69: expected int *pi
kernel/futex.c:2515:69: got unsigned int *<noident>
Since all of its users were using 'unsigned int' already, it could
be changed safely.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
kernel/futex.c | 2 +-
kernel/futex_compat.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/futex.c b/kernel/futex.c
index 6a3a5fa..464de27 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -2458,7 +2458,7 @@ retry:
*/
static inline int fetch_robust_entry(struct robust_list __user **entry,
struct robust_list __user * __user *head,
- int *pi)
+ unsigned int *pi)
{
unsigned long uentry;
diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
index d49afb2..06da4df 100644
--- a/kernel/futex_compat.c
+++ b/kernel/futex_compat.c
@@ -19,7 +19,7 @@
*/
static inline int
fetch_robust_entry(compat_uptr_t *uentry, struct robust_list __user **entry,
- compat_uptr_t __user *head, int *pi)
+ compat_uptr_t __user *head, unsigned int *pi)
{
if (get_user(*uentry, head))
return -EFAULT;
--
1.7.2.2
next reply other threads:[~2010-09-14 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 12:43 Namhyung Kim [this message]
2010-09-14 12:43 ` [PATCH 2/3] futex: mark restart_block.futex.uaddr as a __user pointer Namhyung Kim
2010-09-18 10:22 ` [tip:core/futexes] futex: Mark restart_block.futex.uaddr[2] __user tip-bot for Namhyung Kim
2010-09-14 12:43 ` [PATCH 3/3] futex: add lock context annotations Namhyung Kim
2010-09-18 10:22 ` [tip:core/futexes] futex: Add " tip-bot for Namhyung Kim
2010-09-18 10:22 ` [tip:core/futexes] futex: Change 3rd arg of fetch_robust_entry() to unsigned int* tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284468228-8723-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dvhltc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®