mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Mayhar <fmayhar@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Nick Piggin <npiggin@suse.de>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: VFS scalability git tree
Date: Tue, 14 Sep 2010 16:02:32 -0700	[thread overview]
Message-ID: <1284505352.26440.7.camel@bobble.smo.corp.google.com> (raw)
In-Reply-To: <20100914222612.GA23871@infradead.org>

On Tue, 2010-09-14 at 18:26 -0400, Christoph Hellwig wrote:
> Nick,
> 
> what's the plan for going ahead with the VFS scalability work?  We're
> pretty late in the 2.6.36 cycle now and it would be good to get the next
> batch prepared and reivew so that it can get some testing in -next.
> 
> As mentioned before my preference would be the inode lock splitup and
> related patches - they are relatively simple and we're already seeing
> workloads where inode_lock really hurts in the writeback code.

For the record, while I've been quiet here (really busy) I have run a
bunch of pretty serious tests against the original set of patches (note:
_not_ the latest bits in Nick's tree, I have those queued up but haven't
gotten to them yet).  So far I haven't seen any instability at all.

(I did see one case in which a test that does a _lot_ of network traffic
with tons of sockets saw a 20+% performance hit on a system with a
relatively moderate number of cores but I haven't had the time to
characterize it better and want to test against the newer bits in any
event.  Sorry to be so vague, I can't really be more specific at this
point.  Nailing this down is _also_ on my list.)

Performance notwithstanding, I'm impressed with the stability of those
original patches.  I've run VM stress tests against it, FS stress tests,
lots of benchmarks and a bunch of other stuff and it's solid, no crashes
nor any anomalous behavior.

That being the case, I would vote enthusiastically for bringing in the
inode_lock splitup as soon as is feasible.
-- 
Frank Mayhar <fmayhar@google.com>
Google, Inc.


      reply	other threads:[~2010-09-14 23:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 19:01 Nick Piggin
2010-07-23 11:13 ` Dave Chinner
2010-07-23 14:04   ` [PATCH 0/2] vfs scalability tree fixes Dave Chinner
2010-07-23 16:09     ` Nick Piggin
2010-07-23 14:04   ` [PATCH 1/2] xfs: fix shrinker build Dave Chinner
2010-07-23 14:04   ` [PATCH 2/2] xfs: shrinker should use a per-filesystem scan count Dave Chinner
2010-07-23 15:51   ` VFS scalability git tree Nick Piggin
2010-07-24  0:21     ` Dave Chinner
2010-07-23 11:17 ` Christoph Hellwig
2010-07-23 15:42   ` Nick Piggin
2010-07-23 13:55 ` Dave Chinner
2010-07-23 16:16   ` Nick Piggin
2010-07-27  7:05   ` Nick Piggin
2010-07-27 11:09     ` Nick Piggin
2010-07-27 13:18     ` Dave Chinner
2010-07-27 15:09       ` Nick Piggin
2010-07-28  4:59         ` Dave Chinner
2010-07-23 15:35 ` Nick Piggin
2010-07-24  8:43 ` KOSAKI Motohiro
2010-07-24  8:44   ` [PATCH 1/2] vmscan: shrink_all_slab() use reclaim_state instead the return value of shrink_slab() KOSAKI Motohiro
2010-07-24 12:05     ` KOSAKI Motohiro
2010-07-24  8:46   ` [PATCH 2/2] vmscan: change shrink_slab() return tyep with void KOSAKI Motohiro
2010-07-24 10:54   ` VFS scalability git tree KOSAKI Motohiro
2010-07-26  5:41 ` Nick Piggin
2010-07-28 10:24   ` Nick Piggin
2010-07-30  9:12 ` Nick Piggin
2010-08-03  0:27   ` john stultz
2010-08-03  5:44     ` Nick Piggin
2010-09-14 22:26       ` Christoph Hellwig
2010-09-14 23:02         ` Frank Mayhar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284505352.26440.7.camel@bobble.smo.corp.google.com \
    --to=fmayhar@google.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome