From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753284Ab0IOM16 (ORCPT ); Wed, 15 Sep 2010 08:27:58 -0400 Received: from gir.skynet.ie ([193.1.99.77]:45553 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604Ab0IOM1z (ORCPT ); Wed, 15 Sep 2010 08:27:55 -0400 From: Mel Gorman To: Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Linux Kernel List , Johannes Weiner , Minchan Kim , Wu Fengguang , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Mel Gorman Subject: [PATCH 3/8] vmscan: Synchronous lumpy reclaim should not call congestion_wait() Date: Wed, 15 Sep 2010 13:27:46 +0100 Message-Id: <1284553671-31574-4-git-send-email-mel@csn.ul.ie> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1284553671-31574-1-git-send-email-mel@csn.ul.ie> References: <1284553671-31574-1-git-send-email-mel@csn.ul.ie> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: KOSAKI Motohiro congestion_wait() mean "waiting queue congestion is cleared". However, synchronous lumpy reclaim does not need this congestion_wait() as shrink_page_list(PAGEOUT_IO_SYNC) uses wait_on_page_writeback() and it provides the necessary waiting. Signed-off-by: KOSAKI Motohiro Signed-off-by: Mel Gorman Reviewed-by: Minchan Kim Reviewed-by: Johannes Weiner Reviewed-by: Wu Fengguang Reviewed-by: KAMEZAWA Hiroyuki --- mm/vmscan.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 652650f..e8b5224 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1341,8 +1341,6 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, /* Check if we should syncronously wait for writeback */ if (should_reclaim_stall(nr_taken, nr_reclaimed, priority, sc)) { - congestion_wait(BLK_RW_ASYNC, HZ/10); - /* * The attempt at page out may have made some * of the pages active, mark them inactive again. -- 1.7.1