From: Namhyung Kim <namhyung@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] block: add assert_spin_locked() to ensure lock is held
Date: Wed, 15 Sep 2010 21:33:27 +0900 [thread overview]
Message-ID: <1284554007-13077-1-git-send-email-namhyung@gmail.com> (raw)
Use assert_spin_locked() macro in order to ensure that queue_lock
must be held prior to calling some EXPORTed functions.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
block/blk-core.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 32a1c12..b849064 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -975,6 +975,8 @@ EXPORT_SYMBOL(blk_make_request);
*/
void blk_requeue_request(struct request_queue *q, struct request *rq)
{
+ assert_spin_locked(q->queue_lock);
+
blk_delete_timer(rq);
blk_clear_rq_complete(rq);
trace_block_rq_requeue(q, rq);
@@ -1098,6 +1100,8 @@ EXPORT_SYMBOL_GPL(part_round_stats);
*/
void __blk_put_request(struct request_queue *q, struct request *req)
{
+ assert_spin_locked(q->queue_lock);
+
if (unlikely(!q))
return;
if (unlikely(--req->ref_count))
@@ -1729,6 +1733,8 @@ unsigned int blk_rq_err_bytes(const struct request *rq)
unsigned int bytes = 0;
struct bio *bio;
+ assert_spin_locked(rq->q->queue_lock);
+
if (!(rq->cmd_flags & REQ_MIXED_MERGE))
return blk_rq_bytes(rq);
@@ -1811,6 +1817,8 @@ struct request *blk_peek_request(struct request_queue *q)
struct request *rq;
int ret;
+ assert_spin_locked(q->queue_lock);
+
while ((rq = __elv_next_request(q)) != NULL) {
if (!(rq->cmd_flags & REQ_STARTED)) {
/*
@@ -1926,6 +1934,8 @@ void blk_dequeue_request(struct request *rq)
*/
void blk_start_request(struct request *req)
{
+ assert_spin_locked(req->q->queue_lock);
+
blk_dequeue_request(req);
/*
@@ -1959,6 +1969,8 @@ struct request *blk_fetch_request(struct request_queue *q)
{
struct request *rq;
+ assert_spin_locked(q->queue_lock);
+
rq = blk_peek_request(q);
if (rq)
blk_start_request(rq);
--
1.7.2.2
next reply other threads:[~2010-09-15 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 12:33 Namhyung Kim [this message]
2010-09-15 12:48 ` Jens Axboe
2010-09-15 13:15 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284554007-13077-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®