From: Steven Rostedt <rostedt@goodmis.org>
To: Valdis.Kletnieks@vt.edu
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/3] tracing: Remove leftover FTRACE_ENABLE/DISABLE_MCOUNT enums
Date: Wed, 15 Sep 2010 12:21:26 -0400 [thread overview]
Message-ID: <1284567686.5701.129.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <11102.1284567033@localhost>
On Wed, 2010-09-15 at 12:10 -0400, Valdis.Kletnieks@vt.edu wrote:
> On Tue, 14 Sep 2010 23:01:42 EDT, Steven Rostedt said:
> > From: Steven Rostedt <srostedt@redhat.com>
> >
> > The enums for FTRACE_ENABLE_MCOUNT and FTRACE_DISABLE_MCOUNT were
> > used as commands to ftrace_run_update_code(). But these commands
> > were used by the old nasty ftrace daemon that has long been slain.
>
> > - FTRACE_START_FUNC_RET = (1 << 5),
> > - FTRACE_STOP_FUNC_RET = (1 << 6),
> > + FTRACE_START_FUNC_RET = (1 << 3),
> > + FTRACE_STOP_FUNC_RET = (1 << 4),
>
> This renumber isn't visible to user space, correct? (Asking because the enable/
> disable apparently *were* visible to the since-slain userspace daemon)
Nope, it's not visible to userspace, and the slain-daemon was a kernel
thread, not userspace.
-- Steve
next prev parent reply other threads:[~2010-09-15 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 3:01 [PATCH 0/3] [GIT PULL] tracing: ftrace features and clean ups Steven Rostedt
2010-09-15 3:01 ` [PATCH 1/3] tracing: Add funcgraph-irq option for function graph tracer Steven Rostedt
2010-09-15 3:01 ` [PATCH 2/3] tracing: Do not trace in irq when funcgraph-irq option is zero Steven Rostedt
2010-09-15 3:01 ` [PATCH 3/3] tracing: Remove leftover FTRACE_ENABLE/DISABLE_MCOUNT enums Steven Rostedt
2010-09-15 16:10 ` Valdis.Kletnieks
2010-09-15 16:21 ` Steven Rostedt [this message]
2010-09-15 8:29 ` [PATCH 0/3] [GIT PULL] tracing: ftrace features and clean ups Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284567686.5701.129.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®