From: Namhyung Kim <namhyung@gmail.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Jiri Kosina <trivial@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH UPDATED 1/2] ida: document IDA_BITMAP_LONGS calculation
Date: Thu, 16 Sep 2010 01:30:19 +0900 [thread overview]
Message-ID: <1284568219-14574-1-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <20100915082217.6bf82715.rdunlap@xenotime.net>
IDA_BITMAP_LONGS value is calculated take into account struct ida_bitmap
not to waste memory space. Comment it.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
---
include/linux/idr.h | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/idr.h b/include/linux/idr.h
index e968db7..3f4b718 100644
--- a/include/linux/idr.h
+++ b/include/linux/idr.h
@@ -117,10 +117,13 @@ void idr_init(struct idr *idp);
/*
* IDA - IDR based id allocator, use when translation from id to
* pointer isn't necessary.
+ *
+ * IDA_BITMAP_LONGS is calculated to be one less to accommodate
+ * ida_bitmap->nr_busy so that the whole struct fits in 128 bytes.
*/
#define IDA_CHUNK_SIZE 128 /* 128 bytes per chunk */
-#define IDA_BITMAP_LONGS (128 / sizeof(long) - 1)
-#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8)
+#define IDA_BITMAP_LONGS (IDA_CHUNK_SIZE / sizeof(long) - 1)
+#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8)
struct ida_bitmap {
long nr_busy;
--
1.7.2.2
next prev parent reply other threads:[~2010-09-15 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 12:46 [PATCH RESEND " Namhyung Kim
2010-09-15 12:46 ` [PATCH RESEND 2/2] ext2: trivial: fix a typo on comment in ext2/inode.c Namhyung Kim
2010-09-15 15:22 ` [PATCH RESEND 1/2] ida: document IDA_BITMAP_LONGS calculation Randy Dunlap
2010-09-15 16:30 ` Namhyung Kim [this message]
2010-09-15 16:32 ` [PATCH UPDATED " Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284568219-14574-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®